Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: backport fixes into v1.x for rc5 #1987

Merged
merged 7 commits into from
Jun 23, 2023
Merged

chore: backport fixes into v1.x for rc5 #1987

merged 7 commits into from
Jun 23, 2023

Conversation

cmwaters
Copy link
Contributor

@cmwaters cmwaters commented Jun 23, 2023

This PR backports the following commits in preparation for rc5

Ideally we should MERGE COMMIT and not SQUASH COMMIT so we can preserve the commit history

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

evan-forbes and others added 6 commits June 23, 2023 14:25
## Overview

closes #1982 

## Checklist

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [x] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
Modifies the app such that `PrepareProposal` allows for panics and `ProcessProposal` catches them and votes nil
AnteHandler Decorator that ensures that PFBs have allocated a sufficient amount of gas
@MSevey MSevey requested a review from a team June 23, 2023 12:33
@cmwaters cmwaters self-assigned this Jun 23, 2023
x/blob/ante/ante.go Outdated Show resolved Hide resolved
@evan-forbes
Copy link
Member

we also have #1851 (review), but as stated there, while its not an unplanned validity rule, it is an arguably not necessary change to the state machine. Definitley not blocking on merging that, I think we should merge this as soon as possible and if we don't get #1851, then we will just have to deal with overwriting the genesis state forever, which is nbd

@MSevey MSevey requested a review from a team June 23, 2023 13:12
@codecov-commenter
Copy link

Codecov Report

Merging #1987 (db3e658) into v1.x (9bc84d3) will increase coverage by 0.14%.
The diff coverage is 28.84%.

@@            Coverage Diff             @@
##             v1.x    #1987      +/-   ##
==========================================
+ Coverage   21.21%   21.35%   +0.14%     
==========================================
  Files         120      122       +2     
  Lines       13695    13726      +31     
==========================================
+ Hits         2905     2931      +26     
- Misses      10500    10505       +5     
  Partials      290      290              
Impacted Files Coverage Δ
app/ante.go 0.00% <0.00%> (ø)
app/app.go 4.51% <0.00%> (+0.03%) ⬆️
app/prepare_proposal.go 0.00% <0.00%> (ø)
app/process_proposal.go 0.00% <0.00%> (ø)
app/validate_txs.go 0.00% <0.00%> (ø)
test/util/testnode/node_interaction_api.go 0.00% <ø> (ø)
x/blob/types/blob_tx.go 14.73% <ø> (ø)
x/blob/ante/ante.go 88.46% <88.46%> (ø)
x/blob/keeper/keeper.go 82.75% <100.00%> (ø)
x/blob/types/payforblob.go 72.90% <100.00%> (+1.47%) ⬆️

@cmwaters cmwaters merged commit ba0de2a into v1.x Jun 23, 2023
@cmwaters cmwaters deleted the cal/backport-fixes branch June 23, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants