-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: backport fixes into v1.x for rc5 #1987
Conversation
## Overview closes #1982 ## Checklist - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords
Modifies the app such that `PrepareProposal` allows for panics and `ProcessProposal` catches them and votes nil
AnteHandler Decorator that ensures that PFBs have allocated a sufficient amount of gas
we also have #1851 (review), but as stated there, while its not an unplanned validity rule, it is an arguably not necessary change to the state machine. Definitley not blocking on merging that, I think we should merge this as soon as possible and if we don't get #1851, then we will just have to deal with overwriting the genesis state forever, which is nbd |
Codecov Report
@@ Coverage Diff @@
## v1.x #1987 +/- ##
==========================================
+ Coverage 21.21% 21.35% +0.14%
==========================================
Files 120 122 +2
Lines 13695 13726 +31
==========================================
+ Hits 2905 2931 +26
- Misses 10500 10505 +5
Partials 290 290
|
This PR backports the following commits in preparation for rc5
Ideally we should MERGE COMMIT and not SQUASH COMMIT so we can preserve the commit history
Checklist