refactor(testnode): create genTx on Export (backport #3673)
#3691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Closes #3662 Before, genTx transactions were created prematurely via [`WithValidators`](https://github.com/rootulp/celestia-app/blob/34cd4b34d99e27c5e8611abab6aaecc550499045/test/util/testnode/config.go#L123) which was problematic if a user tried to later override the chainID via `WithChainID` because the genTx transactions would use the default chain ID but the state machine would be created with a custom chain ID. This PR refactors the genTx creation to happen only when `genesis.Export` is invoked which is _after_ a user configures a custom chain ID. (cherry picked from commit 1703fe2)
|
Closing this and combining it with #3689 because tests will fail there until this is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3662
Before, genTx transactions were created prematurely via
WithValidatorswhich was problematic if a user tried to later override the chainID viaWithChainIDbecause the genTx transactions would use the default chain ID but the state machine would be created with a custom chain ID.This PR refactors the genTx creation to happen only when
genesis.Exportis invoked which is after a user configures a custom chain ID.This is an automatic backport of pull request #3673 done by Mergify.