refactor(testnode): create genTx on Export (backport #3673)

app/test/testnode_test.go

@@ -0,0 +1,18 @@
+package app_test
+
+import (
+	"testing"
+
+	"github.com/celestiaorg/celestia-app/v2/test/util/testnode"
+)
+
+func Test_testnode(t *testing.T) {
+	t.Run("testnode can start a network with default chain ID", func(t *testing.T) {
+		testnode.NewNetwork(t, testnode.DefaultConfig())
+	})
+	t.Run("testnode can start a network with a custom chain ID", func(t *testing.T) {
+		chainID := "custom-chain-id"
+		config := testnode.DefaultConfig().WithChainID(chainID)
+		testnode.NewNetwork(t, config)
+	})
+}

test/util/genesis/genesis.go

@@ -167,14 +167,6 @@ func (g *Genesis) AddValidator(val Validator) error {
 		return err
 	}
 
-	// Add the validator's genesis transaction
-	gentx, err := val.GenTx(g.ecfg, g.kr, g.ChainID)
-	if err != nil {
-		return err
-	}
-
-	// install the validator
-	g.genTxs = append(g.genTxs, gentx)
 	g.validators = append(g.validators, val)
 	return nil
 }
@@ -192,7 +184,12 @@ func (g *Genesis) NewValidator(val Validator) error {
 // Export returns the genesis document of the network.
 func (g *Genesis) Export() (*coretypes.GenesisDoc, error) {
 	gentxs := make([]json.RawMessage, 0, len(g.genTxs))
-	for _, genTx := range g.genTxs {
+	for _, val := range g.validators {
+		genTx, err := val.GenTx(g.ecfg, g.kr, g.ChainID)
+		if err != nil {
+			return nil, err
+		}
+
 		bz, err := g.ecfg.TxConfig.TxJSONEncoder()(genTx)
 		if err != nil {
 			return nil, err

test/util/testnode/config.go

@@ -128,8 +128,8 @@ func DefaultConfig() *Config {
 		WithAppOptions(DefaultAppOptions()).
 		WithAppCreator(cmd.NewAppServer).
 		WithSuppressLogs(true).
-		WithConsensusParams(DefaultConsensusParams()).
-		WithSuppressLogs(true)
+		// TODO: consider removing this line because default consensus params is invoked above.
+		WithConsensusParams(DefaultConsensusParams())
 }
 
 func DefaultConsensusParams() *tmproto.ConsensusParams {