chore(go.mod): bump grafana/pyroscope-go deps #3849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristaloleg
requested review from
staheri14 and
evan-forbes
and removed request for
a team
WalkthroughWalkthroughThis pull request updates the Changes
Possibly related PRs
Suggested labels
Tip New featuresWalkthrough comment now includes:
Notes:
Recent review detailsConfiguration used: .coderabbit.yaml Files ignored due to path filters (1)
Files selected for processing (1)
Files skipped from review due to trivial changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
rootulp
approved these changes
Sep 9, 2024
| github.com/grafana/pyroscope-go v1.1.1 // indirect | ||
| github.com/grafana/pyroscope-go/godeltaprof v0.1.6 // indirect | ||
| github.com/grafana/pyroscope-go v1.1.2 // indirect | ||
| github.com/grafana/pyroscope-go/godeltaprof v0.1.8 // indirect |
There was a problem hiding this comment.
Out of curiosity, how did you bump this indirect deps? I also noticed this issue with godeltaprof v0.1.6 and Go 1.23 but I fixed it via a replace directive.
[no change needed] I think we could also fix by bumping the appropriate dep in celestia-core
$ go mod why github.com/grafana/pyroscope-go/godeltaprof
# github.com/grafana/pyroscope-go/godeltaprof
github.com/celestiaorg/celestia-app/v3/cmd/celestia-appd/cmd
github.com/tendermint/tendermint/node
github.com/grafana/pyroscope-go
github.com/grafana/pyroscope-go/godeltaprof
There was a problem hiding this comment.
how did you bump this indirect deps?
Manually! 😂 No, really. Bumping non-major releases is cool due to backward-compatibility assumption in Go modules.
Yeah, this can be also achieved via replace but I don't see a huge reason for that here, more noise than the help.
There was a problem hiding this comment.
Yeah, I can also send the same patch to celestia-core 🫡
There was a problem hiding this comment.
There was a problem hiding this comment.
Sounds good, manual bump works for me.
rootulp
added
backport:v1.x
rootulp
pushed a commit
to celestiaorg/celestia-core
that referenced
this pull request
Sep 9, 2024
Based on suggestion here celestiaorg/celestia-app#3849 (comment) On Go 1.23 I got such failures: ``` % make build --> Updating go.mod --> Updating go.mod in ./test/interchain # github.com/grafana/pyroscope-go/godeltaprof/internal/pprof ../../../go/pkg/mod/github.com/grafana/pyroscope-go/godeltaprof@v0.1.6/internal/pprof/delta_mutex.go:30:20: undefined: runtime_cyclesPerSecond ../../../go/pkg/mod/github.com/grafana/pyroscope-go/godeltaprof@v0.1.6/internal/pprof/proto.go:320:8: undefined: runtime_expandFinalInlineFrame make: *** [build] Error 1 ``` Due to recent change in Go 1.23 where Go team removed some internal things. Simple bump works fine.
ninabarbakadze
approved these changes
Sep 10, 2024
mergify bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
On Go 1.23 I got such failures: ``` % make build --> Updating go.mod --> Updating go.mod in ./test/interchain # github.com/grafana/pyroscope-go/godeltaprof/internal/pprof ../../../go/pkg/mod/github.com/grafana/pyroscope-go/godeltaprof@v0.1.6/internal/pprof/delta_mutex.go:30:20: undefined: runtime_cyclesPerSecond ../../../go/pkg/mod/github.com/grafana/pyroscope-go/godeltaprof@v0.1.6/internal/pprof/proto.go:320:8: undefined: runtime_expandFinalInlineFrame make: *** [build] Error 1 ``` Due to recent change in Go 1.23 where Go team removed some internal things. Simple bump works fine. (cherry picked from commit 2c74ea5) # Conflicts: # go.mod # go.sum
mergify bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
On Go 1.23 I got such failures: ``` % make build --> Updating go.mod --> Updating go.mod in ./test/interchain # github.com/grafana/pyroscope-go/godeltaprof/internal/pprof ../../../go/pkg/mod/github.com/grafana/pyroscope-go/godeltaprof@v0.1.6/internal/pprof/delta_mutex.go:30:20: undefined: runtime_cyclesPerSecond ../../../go/pkg/mod/github.com/grafana/pyroscope-go/godeltaprof@v0.1.6/internal/pprof/proto.go:320:8: undefined: runtime_expandFinalInlineFrame make: *** [build] Error 1 ``` Due to recent change in Go 1.23 where Go team removed some internal things. Simple bump works fine. (cherry picked from commit 2c74ea5)
rootulp
pushed a commit
that referenced
this pull request
Sep 11, 2024
On Go 1.23 I got such failures: ``` % make build --> Updating go.mod --> Updating go.mod in ./test/interchain # github.com/grafana/pyroscope-go/godeltaprof/internal/pprof ../../../go/pkg/mod/github.com/grafana/pyroscope-go/godeltaprof@v0.1.6/internal/pprof/delta_mutex.go:30:20: undefined: runtime_cyclesPerSecond ../../../go/pkg/mod/github.com/grafana/pyroscope-go/godeltaprof@v0.1.6/internal/pprof/proto.go:320:8: undefined: runtime_expandFinalInlineFrame make: *** [build] Error 1 ``` Due to recent change in Go 1.23 where Go team removed some internal things. Simple bump works fine.<hr>This is an automatic backport of pull request #3849 done by [Mergify](https://mergify.com). Co-authored-by: Oleg Kovalov <hey@olegk.dev>
rootulp
pushed a commit
that referenced
this pull request
Sep 11, 2024
Backporting fix as suggested in #3849 (review)
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Go 1.23 I got such failures:
Due to recent change in Go 1.23 where Go team removed some internal things. Simple bump works fine.