Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

header/p2p | header/core: Sanity check batched header requests for adjacency (make sure they are contiguous) #1078

Closed
renaynay opened this issue Sep 12, 2022 · 0 comments · Fixed by #1305
Closed

header/p2p | header/core: Sanity check batched header requests for adjacency (make sure they are contiguous) #1078

renaynay opened this issue Sep 12, 2022 · 0 comments · Fixed by #1305
Labels
area:header Extended header

Comments

@renaynay
Copy link
Member

renaynay commented Sep 12, 2022 •
edited
Loading

Ranges of headers must be verified adjacently against each other in HeaderEx once they are rcvd, so we know if they are faulty the earliest and react on HeaderEx layer by blacklisting them and requesting the range from another peer. This way HeaderEx may always guarantee the requested range is always correct against the first header in the range(which can be incorrect). Currently, they are verified in the Store and we can't do anything about them being wrong.

Implement persistent blacklisting for peers that send bad ranges.
@renaynay renaynay mentioned this issue Sep 12, 2022
Closed
19 tasks
@renaynay renaynay changed the title Ranges of headers must be verified adjacently against each other in HeaderEx once they are rcvd, so we know if they are faulty the earliest and react on HeaderEx layer by blacklisting them and requesting the range from another peer. This way HeaderEx may always guarantee the requested range is always correct against the first header in the range(which can be incorrect). Currently, they are verified in the Store and we can't do anything about them being wrong. header/p2p | header/core: Sanity check batched header requests for adjacency (make sure they are contiguous) Sep 12, 2022
@renaynay renaynay added the area:header Extended header label Sep 12, 2022
@vgonkivs vgonkivs mentioned this issue Nov 29, 2022
Merged
@vgonkivs vgonkivs linked a pull request Nov 29, 2022 that will close this issue
feat(header/p2p): implement GetVerifiedRangeByHeight #1305
Merged
vgonkivs added a commit that referenced this issue Nov 30, 2022
@vgonkivs @renaynay
feat(header/p2p): implement GetVerifiedRangeByHeight (#1305)
8a6de42 
Resolves:
* #1201
* #1078

Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
tzdybal pushed a commit to celestiaorg/go-header that referenced this issue Dec 7, 2022
@vgonkivs @renaynay
feat(header/p2p): implement GetVerifiedRangeByHeight (#1305)
da624a5 
Resolves:
* celestiaorg/celestia-node#1201
* celestiaorg/celestia-node#1078

Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:header Extended header
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(header/p2p): implement GetVerifiedRangeByHeight vgonkivs/celestia-node
1 participant
@renaynay