Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] HeaderEx protocol extensions and hardening #497

Closed
19 tasks done
Wondertan opened this issue Mar 6, 2022 · 5 comments
Closed
19 tasks done

[EPIC] HeaderEx protocol extensions and hardening #497

Wondertan opened this issue Mar 6, 2022 · 5 comments
Assignees
Labels

Comments

@Wondertan
Copy link
Member

Wondertan commented Mar 6, 2022

Mainly we should remove hard dependency on trusted peers, so any node is able to sync headers from any immediate peers and not only trusted and/or bootstrappers. The trusted peers would still remain for automatic subjective initialization. Also, there are multiple networking optimization can be applied to speed up significantly speedup synchronization time.

TODO

@Wondertan Wondertan added area:header Extended header area:p2p labels Mar 6, 2022
@renaynay
Copy link
Member

renaynay commented Mar 6, 2022

Request size configuration for clients and servers. Servers should tell the number of headers they can serve with the hello msg.

I think this should be an optimisation for much later as I'm sure this will be useful for light nodes. I think for now, we can set a comfortable default for all node types that serve headers and then introduce this customisation later. It will be annoying to update the Hello packet in that case though.

We should think about what the Hello packet should contain. We could probably even include MaxHeadersPerRequest (or whatever we wanna call it) field and just set it to a default for now so we don't have to update the packet later

@Wondertan
Copy link
Member Author

Wondertan commented Mar 16, 2022

@renaynay, agree with you. Also, note that there won't be any single hello message and each subprotocol may have its own hello msg. Adding more fields to hello msg shouldn't be problematic in this case together with versioning for subprotocol/wire messages

@renaynay renaynay changed the title HeaderEx protocol extensions [EPIC] HeaderEx protocol extensions and hardening Apr 15, 2022
@renaynay
Copy link
Member

We still need to turn all TODOs in the comment into issues to make this a tracking issue

@renaynay renaynay pinned this issue Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

3 participants