-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EPIC] HeaderEx protocol extensions and hardening #497
Comments
I think this should be an optimisation for much later as I'm sure this will be useful for light nodes. I think for now, we can set a comfortable default for all node types that serve headers and then introduce this customisation later. It will be annoying to update the Hello packet in that case though. We should think about what the Hello packet should contain. We could probably even include |
@renaynay, agree with you. Also, note that there won't be any single hello message and each subprotocol may have its own hello msg. Adding more fields to hello msg shouldn't be problematic in this case together with versioning for subprotocol/wire messages |
We still need to turn all TODOs in the comment into issues to make this a tracking issue |
Mainly we should remove hard dependency on trusted peers, so any node is able to sync headers from any immediate peers and not only trusted and/or bootstrappers. The trusted peers would still remain for automatic subjective initialization. Also, there are multiple networking optimization can be applied to speed up significantly speedup synchronization time.
TODO
ExtendedHeader
s can be requested/sent at once. #191Head
from multiple trusted peers instead of just one and compare them #1019header-sub
HeaderSub topic(or custom header discovery topic as they are pros and cons of a unified topic that needs to be justified) with transient connections and asking them for a header until we find the required one.oneof
forExtendedHeaderRequest
so we can define the request by hashOrNumber #197Head
method sanity checks headers array returned #980CoreExchange
#1282to-1
param such that it does not significantly exceed store.Head() #1316The text was updated successfully, but these errors were encountered: