improvement(header/server): implement timeout for GetRangeByHeight request #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgonkivs
requested review from
renaynay,
Wondertan and
distractedm1nd
as code owners
19 tasks
distractedm1nd
previously approved these changes
Nov 9, 2022
renaynay
previously approved these changes
Nov 10, 2022
|
It would be nice to implement a test for this @vgonkivs 🙏🏻 |
Wondertan
requested changes
Nov 10, 2022
vgonkivs
dismissed stale reviews from renaynay and distractedm1nd
via
b06aa86
Wondertan
previously approved these changes
Nov 10, 2022
distractedm1nd
previously approved these changes
Nov 10, 2022
renaynay
reviewed
Nov 10, 2022
renaynay
reviewed
Nov 10, 2022
vgonkivs
dismissed stale reviews from distractedm1nd and Wondertan
via
3944c7c
renaynay
approved these changes
Nov 10, 2022
distractedm1nd
approved these changes
Nov 10, 2022
Wondertan
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1316