Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Update libp2p to v0.28 #2211

Closed
Wondertan opened this issue May 16, 2023 · 0 comments · Fixed by #2359
Closed

deps: Update libp2p to v0.28 #2211

Wondertan opened this issue May 16, 2023 · 0 comments · Fixed by #2359
Labels
area:p2p kind:deps Pull requests that update a dependency file

Comments

@Wondertan
Copy link
Member

We already tried to update #2127 and then had to revert #2136. The reason is hidden in libp2p/go-libp2p#1574, where responsibility for sending events is now moved to the Network/Swarm from Host. However, mocknet was not updated to send notifications, causing our tests to fail.

I submitted the fix libp2p/go-libp2p#2287 and waiting for the reviews there. Once it lands, we should be able to upgrade. Alternatively, libp2p/go-libp2p#2293 might be introduced, which will likely require some migration

@Wondertan Wondertan added area:p2p kind:deps Pull requests that update a dependency file labels May 16, 2023
@Wondertan Wondertan changed the title deps: Update libp2p to v0.27 deps: Update libp2p to v0.28 Jun 12, 2023
Wondertan added a commit that referenced this issue Jun 15, 2023
Closes #2211

This release brings a whole set of important fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:p2p kind:deps Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant