Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "deps: bump libp2p (#2127)" #2136

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Revert "deps: bump libp2p (#2127)" #2136

merged 1 commit into from
Apr 27, 2023

Conversation

Wondertan
Copy link
Member

@Wondertan Wondertan commented Apr 27, 2023

This reverts commit 82fbba8.

The update breaks the event system. It likely happened after this libp2p/go-libp2p#1574, but we don't need to debug it right now, as simple revert fixes this

@Wondertan Wondertan added kind:deps Pull requests that update a dependency file kind:fix Attached to bug-fixing PRs labels Apr 27, 2023
@Wondertan Wondertan requested a review from renaynay as a code owner April 27, 2023 13:19
@Wondertan Wondertan self-assigned this Apr 27, 2023
@Wondertan
Copy link
Member Author

We would catch this if we put more attention into the Swamp tests

@Wondertan Wondertan enabled auto-merge (squash) April 27, 2023 13:24
@codecov-commenter
Copy link

Codecov Report

Merging #2136 (f4aada8) into main (71fc46d) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2136      +/-   ##
==========================================
- Coverage   55.52%   55.42%   -0.11%     
==========================================
  Files         212      212              
  Lines       13558    13558              
==========================================
- Hits         7528     7514      -14     
- Misses       5268     5283      +15     
+ Partials      762      761       -1     

see 3 files with indirect coverage changes

@Wondertan Wondertan merged commit 1dbd549 into main Apr 27, 2023
@Wondertan Wondertan deleted the hlib/revert-libp2p branch April 27, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:deps Pull requests that update a dependency file kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants