feat(share): EDSStore scaffolding

[distractedm1nd]

Based on top of #1158, replaces #1051

Closes #1107
Closes #1108
Closes #1110
Closes #1111
Closes #1112

[codecov-commenter]

Codecov Report

Merging #1232 (8ce9631) into main (f8bef40) will decrease coverage by 0.30%.
The diff coverage is 55.00%.

@@            Coverage Diff             @@
##             main    #1232      +/-   ##
==========================================
- Coverage   55.42%   55.12%   -0.31%     
==========================================
  Files         178      180       +2     
  Lines       10746    10890     +144     
==========================================
+ Hits         5956     6003      +47     
- Misses       4211     4288      +77     
- Partials      579      599      +20     

Impacted Files	Coverage Δ
nodebuilder/share/service.go	100.00% <ø> (ø)
share/eds/retriever.go	93.71% <ø> (ø)
share/eds/store.go	52.80% <52.80%> (ø)
libs/utils/address.go	59.09% <59.09%> (ø)
nodebuilder/gateway/config.go	68.42% <66.66%> (+5.92%)	⬆️
nodebuilder/rpc/config.go	66.66% <66.66%> (+6.66%)	⬆️
nodebuilder/core/config.go	57.14% <100.00%> (-5.36%)	⬇️
nodebuilder/core/opts.go	0.00% <0.00%> (-50.00%)	⬇️
nodebuilder/das/daser.go	75.00% <0.00%> (-25.00%)	⬇️
header/core/listener.go	52.83% <0.00%> (-5.67%)	⬇️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[renaynay]

• can you doc all noops in blockstore and why they're noops (even if it's just a quick sentence and say check ADR for more info)

[Wondertan]

I deep review of EDStore only. I witsh Blockstore was a separate PR.

General comments for the EDSStore:

• We should wrap errors in each method with meaningful messages via fmt.Errorf(%w)
  • We should start a habit of doing this more often. Our codebase lacks this, and usually, it is hard to grasp what happened from the error message and such wrappings should improve this.
• Each result chan read must obey Context. Check one of the comments for more details on that
• share.Root is actually a full blown DAHeader. The networking layer we build on top, won't have access to it, as we don't want to send it over the wire. Thus, we have to change it to the DataHash or DAHeader.Hash result. Initially, I wanted to ask to do the change in this PR, but then decided to do in a subsequent PR after we clarify this in the Storage ADR first. We also need to come up with cool alias name for the DataHash in share pkg 😂

[walldiss]

Looks good, awesome work!

I've added one small optimisation suggestion.

[distractedm1nd]

Removed blockstore so it can go into a new PR and can be reviewed more thoroughly, this PR is too big rn and the main part of it can get merged

[Wondertan]

There is one general comment still unaddressed from the last review:

• We should wrap errors in each method with meaningful messages via fmt.Errorf(%w)
  • We should start a habit of doing this more often. Our codebase lacks this, and usually, it is hard to grasp what happened from the error message and such wrappings should improve this.

E.g. if the Remove method fails, wrappings will hint to us which actions specifically failed, as Remove consists of Destroying the shard, dropping the index, and Removing the OS file. Without wrappings it will unclear which of this actions errored out

[Wondertan]

Awesome. Thanks man

[renaynay]

Looks good, i've already reviewed this and i guess blockstore has been removed so no real comments other than re topIdx