feat(share): Supplying eds.Store to bridge and full nodes
#1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distractedm1nd
added
area:shares
distractedm1nd
requested review from
renaynay,
Wondertan and
vgonkivs
as code owners
distractedm1nd
force-pushed
the
integrate-edsstore
branch
2 times, most recently
from
d94806c
to
7a71515
Compare
walldiss
previously approved these changes
Nov 24, 2022
Wondertan
reviewed
Nov 29, 2022
distractedm1nd
changed the title
EDSStore to bridge and full nodeseds.Store to bridge and full nodes
distractedm1nd
force-pushed
the
integrate-edsstore
branch
from
687816d
to
b8ee7c3
Compare
distractedm1nd
force-pushed
the
integrate-edsstore
branch
from
b8ee7c3
to
0edd8ee
Compare
renaynay
requested changes
Dec 1, 2022
…ling ctx on start correctly
renaynay
requested changes
Dec 5, 2022
Codecov Report
@@ Coverage Diff @@
## main #1363 +/- ##
=======================================
Coverage 56.02% 56.02%
=======================================
Files 188 188
Lines 11551 11561 +10
=======================================
+ Hits 6471 6477 +6
- Misses 4443 4447 +4
Partials 637 637
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
renaynay
previously approved these changes
Dec 5, 2022
Wondertan
previously approved these changes
Dec 5, 2022
distractedm1nd
dismissed stale reviews from Wondertan and renaynay
via
fd65644
Wondertan
approved these changes
Dec 6, 2022
renaynay
approved these changes
Dec 6, 2022
renaynay
pushed a commit
to renaynay/celestia-node
that referenced
this pull request
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Overview
This PR is based on #1232 and closes #1114. It supplies bridge and full nodes with an instance of EDSStore. The base path is provided by FX from
nodebuilder.Storethrough a string alias.It also fixes a bug that occurred when initializing the eds.Store twice, where the directories already existed. I have swapped MkDir out for MkDirAll, which does not err if the directory already exists.
No test modifications are done, but the Lifecycle tests would fail if it were to fail building or not be able to provide the EDSStore to the nodes.
Checklist