feat(nodebuilder/node): Implement Module
#1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
force-pushed
the
impl-node-mod
branch
from
417af82
to
6e71792
Compare
renaynay
force-pushed
the
impl-node-mod
branch
from
6e71792
to
07fcb16
Compare
3 tasks
renaynay
force-pushed
the
impl-node-mod
branch
from
f8ee7b1
to
da27316
Compare
Codecov Report
@@ Coverage Diff @@
## main #1313 +/- ##
==========================================
- Coverage 55.37% 55.17% -0.21%
==========================================
Files 199 203 +4
Lines 12053 12124 +71
==========================================
+ Hits 6674 6689 +15
- Misses 4714 4770 +56
Partials 665 665
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
renaynay
force-pushed
the
impl-node-mod
branch
3 times, most recently
from
82e27c9
to
8b1f05d
Compare
renaynay
requested review from
Wondertan,
vgonkivs and
distractedm1nd
as code owners
renaynay
force-pushed
the
impl-node-mod
branch
3 times, most recently
from
2279421
to
ddda3a7
Compare
renaynay
force-pushed
the
impl-node-mod
branch
from
6b0b9df
to
195a636
Compare
distractedm1nd
previously approved these changes
Dec 7, 2022
Wondertan
reviewed
Dec 7, 2022
distractedm1nd
previously approved these changes
Dec 8, 2022
Wondertan
reviewed
Dec 8, 2022
refactor(nodebuilder/node): add authverify and authnew methods feat(nodebuilder/node): Add mocks and integrate node module
… module for auth purposes
…dress ryans comments
…favour of AdminInfo method that returns node type and api version, do not return build info
renaynay
force-pushed
the
impl-node-mod
branch
from
6d4f232
to
f4ae5a0
Compare
… permissions methods must return err
distractedm1nd
suggested changes
Dec 12, 2022
distractedm1nd
approved these changes
Dec 13, 2022
liamsi
approved these changes
Dec 13, 2022
renaynay
added a commit
that referenced
this pull request
Dec 20, 2022
Related to #1187 **This PR is based on #1313** **It implements:** * providing a new JWT secret from the `nodebuilder/node` module to both the node module and the rpc server. * auth middleware for the `rpc.Server` that verifies the given token with the server's secret In a follow-up PR will come the ability to create an rpc client with elevated permissions (this branch restricts client access to read-only API methods).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #977