feat(api/rpc): Implement auth middleware on Server
#1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
added
area:rpc
kind:feat
renaynay
force-pushed
the
server-auth
branch
3 times, most recently
from
a98a3b6
to
a1582e9
Compare
Codecov Report
@@ Coverage Diff @@
## main #1402 +/- ##
==========================================
- Coverage 55.33% 54.69% -0.65%
==========================================
Files 180 198 +18
Lines 10962 11903 +941
==========================================
+ Hits 6066 6510 +444
- Misses 4296 4756 +460
- Partials 600 637 +37
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
renaynay
force-pushed
the
server-auth
branch
2 times, most recently
from
272450b
to
045cf73
Compare
renaynay
force-pushed
the
server-auth
branch
2 times, most recently
from
b118c0f
to
1ec02f9
Compare
renaynay
commented
Dec 15, 2022
renaynay
requested review from
Wondertan,
vgonkivs and
distractedm1nd
as code owners
…re in server and provide secret from node module
renaynay
force-pushed
the
server-auth
branch
from
1ec02f9
to
afb894d
Compare
distractedm1nd
suggested changes
Dec 15, 2022
vgonkivs
approved these changes
Dec 15, 2022
distractedm1nd
approved these changes
Dec 20, 2022
Wondertan
approved these changes
Dec 20, 2022
walldiss
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1187
This PR is based on #1313
It implements:
nodebuilder/nodemodule to both the node module and the rpc server.rpc.Serverthat verifies the given token with the server's secretIn a follow-up PR will come the ability to create an rpc client with elevated permissions (this branch restricts client access to read-only API methods).