feat(das): make WaitCatchUp public #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
changed the title
walldiss
force-pushed
the
exspose_waitcatchup_in_daser
branch
from
92df2a4
to
295fee0
Compare
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs and
distractedm1nd
as code owners
renaynay
approved these changes
Nov 18, 2022
Wondertan
added a commit
that referenced
this pull request
Nov 18, 2022
The #1380 made a blocking helper to wait until DASer catching up is done. To use it for tests and further, we have to expose it on the Module either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Exposes WaitCatchUp from DASer to subscribe to catchup event from external caller. Requested for #1341
Checklist