feat(module/das): add WaitCatchUp method to the module #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The #1380 made a blocking helper to wait until DASer catching up is done. To use it for tests and further, we have to expose it on the Module either.
Wondertan
force-pushed
the
hlib/das/add-wait-method
branch
from
082c6a7
to
559e409
Compare
walldiss
previously approved these changes
Nov 21, 2022
vgonkivs
previously approved these changes
Nov 21, 2022
Wondertan
force-pushed
the
hlib/das/add-wait-method
branch
from
474653b
to
a5a3893
Compare
|
Had to fix one test and move it closer to the DAS module. Fixed now |
|
There is one more unit test failure unrelated to this PR |
walldiss
approved these changes
Nov 21, 2022
vgonkivs
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1380 made a blocking helper to wait until catching up is done. To use it for tests and further, we have to expose it on the Module either.