feat(share/discovery): Ensure only one instance of EnsurePeers is running #1642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
force-pushed
the
one_instance_of_ensure_running
branch
from
35e0d09 to
05c467d
Compare
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs and
distractedm1nd
as code owners
Wondertan
requested changes
Jan 26, 2023
Codecov Report
@@ Coverage Diff @@
## main #1642 +/- ##
==========================================
- Coverage 54.91% 54.91% -0.01%
==========================================
Files 231 231
Lines 14995 14999 +4
==========================================
+ Hits 8235 8236 +1
- Misses 5880 5882 +2
- Partials 880 881 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
walldiss
force-pushed
the
one_instance_of_ensure_running
branch
from
f144c8a to
1e3482f
Compare
Wondertan
approved these changes
Jan 26, 2023
renaynay
approved these changes
Jan 26, 2023
walldiss
added a commit
to walldiss/celestia-node
that referenced
this pull request
Jan 26, 2023
…ning (celestiaorg#1642) ensure only one instance of EnsurePeers is running
walldiss
added a commit
to walldiss/celestia-node
that referenced
this pull request
Jan 26, 2023
…ning (celestiaorg#1642) ensure only one instance of EnsurePeers is running
walldiss
added a commit
to walldiss/celestia-node
that referenced
this pull request
Jan 26, 2023
…ning (celestiaorg#1642) ensure only one instance of EnsurePeers is running
distractedm1nd
pushed a commit
to distractedm1nd/celestia-node
that referenced
this pull request
Jan 26, 2023
…ning (celestiaorg#1642) ensure only one instance of EnsurePeers is running
renaynay
pushed a commit
to renaynay/celestia-node
that referenced
this pull request
Jan 31, 2023
…ning (celestiaorg#1642) ensure only one instance of EnsurePeers is running
renaynay
pushed a commit
that referenced
this pull request
Feb 1, 2023
…ning (#1642) ensure only one instance of EnsurePeers is running
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #1613
Test will be implemented in a scope of #1612
Checklist
New and updated code has new and/or updated testing