Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ipld): removing nmt hasher #1651

Merged
merged 2 commits into from
Feb 2, 2023
Merged

refactor(ipld): removing nmt hasher #1651

merged 2 commits into from
Feb 2, 2023

Conversation

distractedm1nd
Copy link
Collaborator

@distractedm1nd distractedm1nd commented Jan 27, 2023 •
edited
Loading

Overview

Removes NMT hasher, updating to the new release.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@distractedm1nd distractedm1nd added area:ipld IPLD plugin kind:deps Pull requests that update a dependency file labels Jan 27, 2023
@distractedm1nd distractedm1nd self-assigned this Jan 27, 2023
liamsi
liamsi reviewed Jan 27, 2023
View reviewed changes
This was referenced Jan 30, 2023
Merged
Closed
@distractedm1nd distractedm1nd mentioned this pull request Feb 1, 2023
Merged
liamsi pushed a commit to celestiaorg/nmt that referenced this pull request Feb 2, 2023
@distractedm1nd
fix: use baseHasher.Size for sha256Len instead of n.Size (#93)
b04eea5 
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview
This PR fixes the bug included in the last release, that resulted
(silently) in producing a different hash than the original hasher.

Related: 
celestiaorg/celestia-core#954
celestiaorg/celestia-node#1651
<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 
-->
@distractedm1nd distractedm1nd marked this pull request as ready for review February 2, 2023 11:02
Wondertan
Wondertan approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💟

@Wondertan Wondertan mentioned this pull request Feb 2, 2023
Merged
5 tasks
@distractedm1nd distractedm1nd merged commit a60c24f into celestiaorg:main Feb 2, 2023
vgonkivs pushed a commit to vgonkivs/celestia-node that referenced this pull request Feb 2, 2023
@distractedm1nd @vgonkivs
refactor(ipld): removing nmt hasher (celestiaorg#1651)
3df824b
renaynay pushed a commit to renaynay/celestia-node that referenced this pull request Feb 2, 2023
@distractedm1nd @renaynay
refactor(ipld): removing nmt hasher (celestiaorg#1651)
fa776f3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamsi liamsi liamsi left review comments

@Wondertan Wondertan Wondertan approved these changes

@renaynay renaynay renaynay approved these changes

@vgonkivs vgonkivs Awaiting requested review from vgonkivs vgonkivs is a code owner

Assignees

@distractedm1nd distractedm1nd

Labels
area:ipld IPLD plugin kind:deps Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@distractedm1nd @liamsi @Wondertan @renaynay