refactor(share)!: have NamespacedShares fields use snake_case in JSON #2633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distractedm1nd
added
area:shares
distractedm1nd
requested review from
renaynay,
Wondertan,
vgonkivs and
walldiss
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2633 +/- ##
==========================================
+ Coverage 50.94% 51.04% +0.10%
==========================================
Files 158 158
Lines 10576 10576
==========================================
+ Hits 5388 5399 +11
+ Misses 4712 4703 -9
+ Partials 476 474 -2
|
evan-forbes
pushed a commit
to celestiaorg/nmt
that referenced
this pull request
Aug 31, 2023
) Related: celestiaorg/celestia-node#2631, celestiaorg/celestia-node#2633 --------- Co-authored-by: Rootul P <rootulp@gmail.com>
renaynay
previously approved these changes
Sep 4, 2023
Wondertan
previously approved these changes
Sep 4, 2023
distractedm1nd
dismissed stale reviews from renaynay and Wondertan
via
12f7376
Wondertan
approved these changes
Sep 4, 2023
renaynay
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #2631 , does not fix without nmt PR and release