Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comply with breaking change of "refactor(share)!: have NamespacedShares fields use snake_case in JSON" #49

Closed
Tracked by #47
nashqueue opened this issue Sep 11, 2023 · 0 comments · Fixed by #52
Closed
Tracked by #47

Comply with breaking change of "refactor(share)!: have NamespacedShares fields use snake_case in JSON" #49

nashqueue opened this issue Sep 11, 2023 · 0 comments · Fixed by #52
Assignees
@Manav-Aggarwal
Labels
T:dependencies

Comments

@nashqueue
Copy link
Member

nashqueue commented Sep 11, 2023 •
edited
Loading

related issue celestiaorg/celestia-node#2633

cc @distractedm1nd
@nashqueue nashqueue mentioned this issue Sep 11, 2023
Closed
@nashqueue nashqueue removed their assignment Sep 11, 2023
@Manav-Aggarwal Manav-Aggarwal self-assigned this Sep 12, 2023
@Manav-Aggarwal Manav-Aggarwal mentioned this issue Sep 12, 2023
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Sep 12, 2023
@Manav-Aggarwal
Update Namespaced shares fields use snake_case in JSON (#52)
46c261e 
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview
Closes: #49 

<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 
-->

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [ ] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Manav-Aggarwal Manav-Aggarwal

Labels
T:dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Namespaced shares fields use snake_case in JSON celestiaorg/celestia-openrpc
2 participants
@Manav-Aggarwal @nashqueue