Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Namespaced shares fields use snake_case in JSON #52

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Update Namespaced shares fields use snake_case in JSON #52

merged 1 commit into from
Sep 12, 2023

Conversation

Manav-Aggarwal
Copy link
Member

@Manav-Aggarwal Manav-Aggarwal commented Sep 12, 2023 •
edited
Loading

Overview

Closes: #49

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@nashqueue nashqueue force-pushed the manav/update_namespaced_shares_fields branch from ddf4347 to 4f3f49a Compare September 12, 2023 11:45
@Manav-Aggarwal Manav-Aggarwal force-pushed the manav/update_namespaced_shares_fields branch from 4f3f49a to b8156e5 Compare September 12, 2023 14:57
@Manav-Aggarwal Manav-Aggarwal force-pushed the manav/update_namespaced_shares_fields branch from b8156e5 to 1472521 Compare September 12, 2023 20:36
jcstein
jcstein approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@jcstein jcstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@Manav-Aggarwal Manav-Aggarwal added this pull request to the merge queue Sep 12, 2023
Merged via the queue into main with commit 46c261e Sep 12, 2023
10 checks passed
@Manav-Aggarwal Manav-Aggarwal deleted the manav/update_namespaced_shares_fields branch September 12, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nashqueue nashqueue nashqueue approved these changes

@jcstein jcstein jcstein approved these changes

@distractedm1nd distractedm1nd distractedm1nd approved these changes

@gupadhyaya gupadhyaya gupadhyaya approved these changes

@S1nus S1nus Awaiting requested review from S1nus

@tzdybal tzdybal Awaiting requested review from tzdybal

@tuxcanfly tuxcanfly Awaiting requested review from tuxcanfly

Assignees

@Manav-Aggarwal Manav-Aggarwal

Labels
T:dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Comply with breaking change of "refactor(share)!: have NamespacedShares fields use snake_case in JSON"
5 participants
@Manav-Aggarwal @gupadhyaya @distractedm1nd @jcstein @nashqueue