Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps!: bump nmt, breaking JSON RPC return types including nmt Proofs #2728

Merged
merged 1 commit into from
Sep 21, 2023
Merged

deps!: bump nmt, breaking JSON RPC return types including nmt Proofs #2728

merged 1 commit into from
Sep 21, 2023

Conversation

distractedm1nd
Copy link
Collaborator

@distractedm1nd distractedm1nd added kind:deps Pull requests that update a dependency file kind:break! Attached to breaking PRs labels Sep 18, 2023
@distractedm1nd distractedm1nd self-assigned this Sep 18, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2728 (f6d24e9) into main (fd90764) will decrease coverage by 0.19%.
Report is 5 commits behind head on main.
The diff coverage is 38.29%.

@@            Coverage Diff             @@
##             main    #2728      +/-   ##
==========================================
- Coverage   51.51%   51.32%   -0.19%     
==========================================
  Files         162      163       +1     
  Lines       10755    10784      +29     
==========================================
- Hits         5540     5535       -5     
- Misses       4734     4764      +30     
- Partials      481      485       +4
Files Changed Coverage Δ
share/eds/cache/doublecache.go 0.00% <0.00%> (ø)
share/eds/store.go 69.13% <57.14%> (-0.45%) ⬇️
share/eds/utils.go 66.66% <75.00%> (-11.91%) ⬇️
share/eds/blockstore.go 38.70% <100.00%> (+1.20%) ⬆️

... and 5 files with indirect coverage changes

@Wondertan
Copy link
Member

Why is it breaking again?

@distractedm1nd
Copy link
Collaborator Author

@Wondertan #2631

ramin
ramin reviewed Sep 19, 2023
View reviewed changes
Copy link
Contributor

@ramin ramin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to do follow on work to fix rpc after this?

@ramin ramin mentioned this pull request Sep 19, 2023
Closed
@distractedm1nd
Copy link
Collaborator Author

@ramin Yes! We need to update the openrpc json after this, but its not in main yet

@ramin ramin self-requested a review September 21, 2023 08:41
@ramin ramin merged commit 2b61033 into main Sep 21, 2023
17 of 20 checks passed
@ramin ramin deleted the bump-nmt branch September 21, 2023 08:51
This was referenced Sep 21, 2023
Closed
Merged
vgonkivs pushed a commit to vgonkivs/celestia-node that referenced this pull request Oct 5, 2023
@distractedm1nd @vgonkivs
deps!: bump nmt, breaking JSON RPC return types including nmt Proofs (c…
c5ceb60 
…elestiaorg#2728)

Related: celestiaorg/nmt#233
github-merge-queue bot pushed a commit to celestiaorg/celestia-openrpc that referenced this pull request Oct 17, 2023
@distractedm1nd @nashqueue
fix: update nmt and fix blob proof serialization (#55)
fe2f88b 
Upgrades to match node [v0.11.0-rc14 - Cache
Fixes](https://github.com/celestiaorg/celestia-node/releases/tag/v0.11.0-rc14)

Related: celestiaorg/celestia-node#2728

Co-authored-by: nashqueue <99758629+nashqueue@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramin ramin ramin approved these changes

@walldiss walldiss walldiss approved these changes

@Wondertan Wondertan Wondertan approved these changes

@renaynay renaynay Awaiting requested review from renaynay renaynay is a code owner

@vgonkivs vgonkivs Awaiting requested review from vgonkivs vgonkivs is a code owner

Assignees

@distractedm1nd distractedm1nd

Labels
kind:break! Attached to breaking PRs kind:deps Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@distractedm1nd @codecov-commenter @Wondertan @ramin @walldiss