fix: replacing jsonProof with pb.Proof

[distractedm1nd]

jsonProof is not necessary when we already have pb.Proof, which caused issues because of mismatching field names.

Related: celestiaorg/celestia-node#2631
Specifically: celestiaorg/celestia-node#2631 (comment)

[codecov]

Codecov Report

Merging #233 (38c7b23) into master (0e219c8) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #233   +/-   ##
=======================================
  Coverage   68.30%   68.30%           
=======================================
  Files           6        6           
  Lines        1325     1325           
=======================================
  Hits          905      905           
  Misses        403      403           
  Partials       17       17           

Files Changed	Coverage Δ
proof.go	90.17% <100.00%> (ø)

[Wondertan]

At this point, we should consider making all the fields on the Proof public (It might be breaking).

It's feels wrong to reuse pb definition for json marshalling, even though it works.

[distractedm1nd]

I still disagree with making fields public only for the point of serialization. These are not fields that should be touched outside of the given methods

[rootulp]

[nit] I think this should be marked breaking (i.e. fix!: in PR title) because it impacts JSON encoding observed in downstream repos (i.e. celestia-node).

[question] Do we need a unit test in this PR that the field names in the proof JSON encoding match what is expected or does that test belong in celestia-node?

[Wondertan]

Actually true, encapsulation for Proofs is more important for security.

These are not fields that should be touched outside of the given methods

Using autogenerated proto for json completely solves consistency between json and proto, as it also autogenerates json tags(TIL), so it's not that bad after all.

[distractedm1nd]

Yeah but the main problem is not being able to define methods on it

[Wondertan]

I meant keeping native go struct

[oblique]

What is the status on this?

[distractedm1nd]

@rootulp Can we get this merged?

[rootulp]

Sorry we need one more @celestiaorg/celestia-core approval.

[ramin]

is there follow on work to fix rpc @distractedm1nd?