fix(pruner): fix find algo so that it does not pass a malformed range into GetRangeByHeight call
#3828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
requested review from
Wondertan,
vgonkivs,
walldiss and
cristaloleg
as code owners
renaynay
changed the title
GetRangeByHeight call
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3828 +/- ##
==========================================
+ Coverage 44.83% 45.29% +0.45%
==========================================
Files 265 311 +46
Lines 14620 21884 +7264
==========================================
+ Hits 6555 9912 +3357
- Misses 7313 10915 +3602
- Partials 752 1057 +305 ☔ View full report in Codecov by Sentry. |
vgonkivs
previously approved these changes
Oct 9, 2024
cristaloleg
previously approved these changes
Oct 9, 2024
walldiss
reviewed
Oct 9, 2024
renaynay
force-pushed
the
fix-pruner-finder
branch
from
715b51e
to
150e9c9
Compare
vgonkivs
previously approved these changes
Oct 17, 2024
walldiss
reviewed
Oct 17, 2024
walldiss
reviewed
Oct 17, 2024
…ffHeight+1` as the `to` parameter for the call down to GetRangeByHeight -- this will ensure `estimatedCutoffHeight` is included in returned range
walldiss
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3823