Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pruner): fix find algo so that it does not pass a malformed range into GetRangeByHeight call #3828

Merged
merged 6 commits into from
Oct 28, 2024
Merged

fix(pruner): fix find algo so that it does not pass a malformed range into GetRangeByHeight call #3828

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
61cc3ef
fix(pruner): fix find algo so that it does not pass a malformed range…
renaynay Oct 8, 2024
150e9c9
doc(pruner): add note to sanity check on estimatedCutoffHeight
renaynay Oct 17, 2024
2b825fa
comment(pruner): add TODO to revert change once go-header change is r…
renaynay Oct 23, 2024
e7fc9c5
fix(pruner): Fix find algo yet again so that it passes `estimatedCuto…
renaynay Oct 23, 2024
c220a8a
doc(pruner): update todo
renaynay Oct 24, 2024
7ccd7c2
Merge branch 'main' into fix-pruner-finder
renaynay Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pruner/find.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,17 @@ func (s *Service) findPruneableHeaders(
return nil, err
}

if lastPruned.Height() == estimatedCutoffHeight {
walldiss marked this conversation as resolved.
Show resolved Hide resolved
if lastPruned.Height() >= estimatedCutoffHeight {
// nothing left to prune
return nil, nil
}

log.Debugw("finder: fetching header range", "last pruned", lastPruned.Height(),
"target height", estimatedCutoffHeight)

headers, err := s.getter.GetRangeByHeight(ctx, lastPruned, estimatedCutoffHeight)
// GetRangeByHeight requests (from:to), where `to` is non-inclusive, we need
// to request one more header than the estimated cutoff
headers, err := s.getter.GetRangeByHeight(ctx, lastPruned, estimatedCutoffHeight+1)
if err != nil {
log.Errorw("failed to get range from header store", "from", lastPruned.Height(),
"to", estimatedCutoffHeight, "error", err)
Expand Down