feat(store): Test all put funcs #3847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3847 +/- ##
==========================================
+ Coverage 44.83% 44.99% +0.16%
==========================================
Files 265 314 +49
Lines 14620 21799 +7179
==========================================
+ Hits 6555 9809 +3254
- Misses 7313 10965 +3652
- Partials 752 1025 +273 ☔ View full report in Codecov by Sentry. |
walldiss
force-pushed
the
refactor-eds-store-tests
branch
from
ca6f4e1
to
074a15f
Compare
walldiss
force-pushed
the
refactor-eds-store-tests
branch
from
074a15f
to
8bf823e
Compare
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs and
cristaloleg
as code owners
cristaloleg
approved these changes
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the EDS store tests to expand coverage. Previously, only the ODSQ4 function was tested, and some scenarios for empty files were missing. The updated tests now cover all file creation functions and include both empty and non-empty file scenarios for the following operations: