Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable markdownlint #106

Closed
rootulp opened this issue Feb 17, 2023 · 0 comments · Fixed by #124
Closed

Enable markdownlint #106

rootulp opened this issue Feb 17, 2023 · 0 comments · Fixed by #124
Assignees
@rootulp

Comments

@rootulp
Copy link
Collaborator

rootulp commented Feb 17, 2023

[no change needed] but markdownlint will complain here because multiple H1 headings are used in the same document. Do we want to enable markdownlint in this repo configure a CI check for it to conform to other celestiaorg repos?

no change needed because this spec can be reviewed without conforming to markdownlint and we can tackle that in a separate issue / PR if desired.

Originally posted by @rootulp in #101 (comment)
@rootulp rootulp mentioned this issue Feb 17, 2023
Merged
@staheri14 staheri14 mentioned this issue Mar 3, 2023
Merged
5 tasks
staheri14 added a commit that referenced this issue Mar 3, 2023
@staheri14
chore: splits the nmt spec into two files and moves them into separat…
682b906 
…e directories (#120)

## Overview
Closes #112 and
informalsystems/audit-celestia#41.
Also, partially addresses #106.

## Checklist

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [x] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
@rootulp rootulp self-assigned this Mar 8, 2023
@rootulp rootulp mentioned this issue Mar 8, 2023
Merged
rootulp added a commit that referenced this issue Mar 8, 2023
@rootulp
chore: enable markdownlint (#124)
e8ad2aa 
Closes #106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: enable markdownlint rootulp/nmt
1 participant
@rootulp