Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo at the nmt documentation #41

Closed
andrijamitrovic23 opened this issue Mar 2, 2023 · 2 comments
Closed

Typo at the nmt documentation #41

andrijamitrovic23 opened this issue Mar 2, 2023 · 2 comments

Comments

@andrijamitrovic23
Copy link
Collaborator

This is a minor issue. There is a typo at the nmt documentation .

The typo is located in the section "NMT Data Structure" under the rule for calculating hash for "Non-leaf Nodes". At the very beginning when children of an intermediary node n are presented the characters r and l should be switched.
@staheri14 staheri14 mentioned this issue Mar 3, 2023
Merged
5 tasks
@staheri14
Copy link

Thanks for reporting the issue, it is addressed in the following PR celestiaorg/nmt#120.

staheri14 added a commit to celestiaorg/nmt that referenced this issue Mar 3, 2023
@staheri14
chore: splits the nmt spec into two files and moves them into separat…
682b906 
…e directories (#120)

## Overview
Closes #112 and
informalsystems/audit-celestia#41.
Also, partially addresses #106.

## Checklist

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [x] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
@staheri14
Copy link

Given that the issue is being addressed, what do you think about closing it? @andrijamitrovic23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ivan-gavran @staheri14 @andrijamitrovic23