-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: Allow to set chunkSize to be set in dataSquare #231
Comments
Additionally, we can follow implicit approach of the constructor and set chunk size on the first SetCell call |
@walldiss could you provide an example of the code that is required to make it work correctly? Can be copied/directed from our hotfix |
Since |
Closes #231 This PR adds a new constructor called `NewExtendedDataSquare` that allows @celestia-node to explicitly set the `chunkSize` on an empty EDS. I choose to not drop the existing `ImportExtendedDataSquare` as proposed in #85 because that would be public API breaking. cc: @Wondertan @walldiss
Closes celestiaorg/rsmt2d#231 This PR adds a new constructor called `NewExtendedDataSquare` that allows @celestia-node to explicitly set the `chunkSize` on an empty EDS. I choose to not drop the existing `ImportExtendedDataSquare` as proposed in celestiaorg/rsmt2d#85 because that would be public API breaking. cc: @Wondertan @walldiss
If DataSquare initialised without chunks,
SetCell
will return chunk size mismatch error on setting first chunk with non 0 size. We need a way to create square without chunks, that will allowSetCell
and will be possible to useGetCell
on. Currently, there is no way to initialise square, providing no chunks and settingchunkSize
to non zero value at the same time.Steps to reproduce:
newDataSquare
with data list of 0 length.SetCell
Solution:
Add chunkSize param to the
newDataSquare
constructorThe text was updated successfully, but these errors were encountered: