feat: NewExtendedDataSquare with chunkSize param
#236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
commented
Jul 6, 2023
| @@ -96,6 +96,49 @@ func TestMarshalJSON(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestNewExtendedDataSquare(t *testing.T) { | |||
There was a problem hiding this comment.
[note for reviewers] I tend to prefer table driven tests but I found it difficult to write a singular table driven test for all the test cases I wanted to cover because the scenarios that cause errors are different.
If reviewers don't like this style of tests, I can try to refactor to something else.
evan-forbes
approved these changes
Jul 6, 2023
walldiss
approved these changes
Jul 7, 2023
This was referenced Jul 7, 2023
staheri14
reviewed
Jul 7, 2023
This was referenced Jul 7, 2023
staheri14
approved these changes
Jul 7, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #231
This PR adds a new constructor called
NewExtendedDataSquarethat allows @celestia-node to explicitly set thechunkSizeon an empty EDS. I choose to not drop the existingImportExtendedDataSquareas proposed in #85 because that would be public API breaking.cc: @Wondertan @walldiss