Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ruff formatter instead of black formatter #136

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Use ruff formatter instead of black formatter #136

merged 1 commit into from
Mar 18, 2024

Conversation

ordabayevy
Copy link
Contributor

@ordabayevy ordabayevy commented Mar 17, 2024 •
edited
Loading

ruff format does (almost) the same thing as black but blazingly fast.

This PR also fixes failing tests due to the new jsonargparse version 4.27.6

@ordabayevy ordabayevy removed the easy label Mar 17, 2024
@ordabayevy ordabayevy requested review from sjfleming and mbabadi March 17, 2024 17:52
sjfleming
sjfleming approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@sjfleming sjfleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ordabayevy ordabayevy merged commit 5495aa8 into main Mar 18, 2024
5 checks passed
@ordabayevy ordabayevy deleted the ruff branch March 18, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjfleming sjfleming sjfleming approved these changes

@mbabadi mbabadi Awaiting requested review from mbabadi

Assignees
No one assigned
Labels
awaiting review easy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ordabayevy @sjfleming