p2p: define DiscReason as uint8 (#24507) #1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All other implementations store disconnect reasons as a single byte, so go-ethereum should do it too.
|
Coverage from tests in coverage: 51.1% of statements across all listed packagescoverage: 61.6% of statements in consensus/istanbul coverage: 41.7% of statements in consensus/istanbul/announce coverage: 54.9% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 24.3% of statements in consensus/istanbul/backend/internal/replica coverage: 71.2% of statements in consensus/istanbul/core coverage: 45.0% of statements in consensus/istanbul/db coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 64.4% of statements in consensus/istanbul/uptime coverage: 51.8% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/randomCommentID: 79e7b93e93 |
Codecov Report
@@ Coverage Diff @@
## master #1886 +/- ##
==========================================
+ Coverage 54.35% 54.41% +0.06%
==========================================
Files 673 673
Lines 88954 88954
==========================================
+ Hits 48349 48406 +57
+ Misses 36953 36894 -59
- Partials 3652 3654 +2
Continue to review full report at Codecov.
|
piersy
added a commit
that referenced
this pull request
May 11, 2022
Cherry picking upstream pr All other implementations store disconnect reasons as a single byte, so go-ethereum should do it too. Co-authored-by: Felix Lange <fjl@twurst.com>
piersy
added a commit
that referenced
this pull request
May 12, 2022
Cherry picking upstream pr All other implementations store disconnect reasons as a single byte, so go-ethereum should do it too. Co-authored-by: Felix Lange <fjl@twurst.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picking this pr from upstream.
All other implementations store disconnect reasons as a single byte,
so go-ethereum should do it too.