p2p: define DiscReason as uint8 #24507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All other implementations store disconnect reason as a single byte.
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Mar 8, 2022
All other implementations store disconnect reasons as a single byte, so go-ethereum should do it too.
JacekGlen
pushed a commit
to JacekGlen/go-ethereum
that referenced
this pull request
May 26, 2022
All other implementations store disconnect reasons as a single byte, so go-ethereum should do it too.
This was referenced Jul 28, 2022
|
dash-eu.luxor.tech:5050. |
jiseongnoh
added a commit
to jiseongnoh/klaytn
that referenced
this pull request
Jul 29, 2022
applied PR ethereum/go-ethereum#24507
9 tasks
ken0x4b656e
added a commit
to stars-labs/heco-chain
that referenced
this pull request
Jul 29, 2022
|
@fjl May be it's better to define DiscReason as uint16, for the compatibility among different versions. |
owen9web3
added a commit
to cube-network/Cube
that referenced
this pull request
Aug 1, 2022
maoueh
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Aug 3, 2022
All other implementations store disconnect reasons as a single byte, so go-ethereum should do it too.
viaweb3
added a commit
to kcc-community/kcc
that referenced
this pull request
Aug 11, 2022
p2p: define DiscReason as uint8 (ethereum#24507)
iczc
pushed a commit
to scroll-tech/go-ethereum
that referenced
this pull request
Oct 8, 2022
All other implementations store disconnect reasons as a single byte, so go-ethereum should do it too.
iczc
added a commit
to scroll-tech/go-ethereum
that referenced
this pull request
Oct 12, 2022
p2p: define DiscReason as uint8 (ethereum#24507) All other implementations store disconnect reasons as a single byte, so go-ethereum should do it too. Co-authored-by: Felix Lange <fjl@twurst.com>
wgr523
pushed a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Mar 23, 2023
p2p: define DiscReason as uint8 (ethereum#24507) All other implementations store disconnect reasons as a single byte, so go-ethereum should do it too.
wgr523
added a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Mar 23, 2023
Problem: GHSA-wjxw-gh3m-7pm5 Fix: add non-negative `if` condition. cannot use fix in geth (ethereum#24507) since modifying DiscReason to uint8 messes up the message encode
wjrjerome
pushed a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Mar 26, 2023
Problem: GHSA-wjxw-gh3m-7pm5 Fix: add non-negative `if` condition. cannot use fix in geth (ethereum#24507) since modifying DiscReason to uint8 messes up the message encode
iquidus
pushed a commit
to ubiq/go-ubiq
that referenced
this pull request
Mar 30, 2023
All other implementations store disconnect reasons as a single byte, so go-ethereum should do it too.
liam-lai
pushed a commit
to XinFinOrg/XDC-Subnet
that referenced
this pull request
May 25, 2023
Problem: GHSA-wjxw-gh3m-7pm5 Fix: add non-negative `if` condition. cannot use fix in geth (ethereum/go-ethereum#24507) since modifying DiscReason to uint8 messes up the message encode
otherview
pushed a commit
to vechain/go-ethereum
that referenced
this pull request
Mar 8, 2024
All other implementations store disconnect reasons as a single byte, so go-ethereum should do it too.
libotony
pushed a commit
to vechain/go-ethereum
that referenced
this pull request
Mar 8, 2024
All other implementations store disconnect reasons as a single byte, so go-ethereum should do it too.
nibty
pushed a commit
to FairCrypto/go-ethereum
that referenced
this pull request
Apr 10, 2024
All other implementations store disconnect reasons as a single byte, so go-ethereum should do it too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All other implementations store disconnect reason as a single byte, so go-ethereum should do it too.