Odis signer refactor #10464
Merged
Odis signer refactor #10464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlb
reviewed
Aug 4, 2023
There was a problem hiding this comment.
Locking the row in getPerformedQueryCount ensures that all other processes will be blocked until this transaction is closed. This prevents users from overdrawing their quota temporarily. This is an opportunity to reduce contention by dropping the lock, since we can live with a temporary quota overdraw.
The quota increase in incrementQueryCount will still work fine without the lock, since the increment operation is atomic.
Comment on lines
101
to
103
| await tableWithLockForTrx(accounts(db, accountsTable), trx) | ||
| .insert(data) | ||
| .timeout(config.db.timeout) |
There was a problem hiding this comment.
I don't think using tableWithLockForTrx does anything in this case. According to the docs it will add locking to select statements by turning them into SELECT ... FOR UPDATE statements. But since no select is happening here, this looks like a no-op.
I think the same applies to the change in L77 and other changes in this commit where only insert and update statements happen.
| @@ -34,6 +34,7 @@ export function countAndThrowDBError<T>( | |||
| } | |||
|
|
|||
| export function tableWithLockForTrx(baseQuery: Knex.QueryBuilder, trx?: Knex.Transaction) { | |||
| // | |||
| if (trx) { | |||
| // Lock relevant database rows for the duration of the transaction | |||
There was a problem hiding this comment.
As far as I understand the docs, this should say
Lock relevant database rows for the duration of the transaction when doing a select
Other operations might create locks due to their normal operations, but will not be modified by calling this function.
|
Adding an index would greatly speed up the read at the cost of slowing down writes to the table. |
alecps
commented
Aug 4, 2023
| db: Knex, | ||
| accountsTable: ACCOUNTS_TABLE, | ||
| account: string, | ||
| logger: Logger, | ||
| trx: Knex.Transaction | ||
| trx?: Knex.Transaction | ||
| ): Promise<void> { | ||
| return meter( | ||
| async () => { | ||
| logger.debug({ account }, 'Incrementing query count') | ||
| if (await getAccountExists(db, accountsTable, account, logger, trx)) { |
There was a problem hiding this comment.
do we need to check if account exists here?
…s/odisRemoveDbLock
Co-authored-by: Mariano Cortesi <mcortesi@gmail.com>
* odis-tracing-node18 * yarn command * Test again * Pray * Pray 2 * Pray 3 * Pray 4 * endpoint traces * Error trace * Span in io.ts * Handle errors - OK * Fix if * IO tracing * Common IO tracing * Event messages * Authenticate tracing * Sign tracing * Span end * Span ends * Controller span * NodeTracerProvider * Trace names * Instrumentations * No ExpressInstrumentation * Remove parentSpan * Request * Ignore paths * parentSpan * Ignore more paths * knex instrumentation * Knex instrumentation * Full node inst + manual * ignoreIncomingPaths for http inst * Comments * No cache build * Common packages * TSlint error 1 * TSlint error 2 * TSlint errors * TSlint errors shorthand * // tslint:disable-next-line:no-floating-promises * Fix tests?
…norepo into alecps/odisRemoveDbLock
…s/odisRemoveDbLock
Co-authored-by: Alec Schaefer <alecps@users.noreply.github.com>
…ecps/odisRemoveDbLock # Conflicts: # packages/phone-number-privacy/combiner/src/pnp/endpoints/quota/io.ts # packages/phone-number-privacy/combiner/src/pnp/endpoints/sign/io.ts # packages/phone-number-privacy/signer/package.json # packages/phone-number-privacy/signer/src/pnp/endpoints/sign/action.ts # yarn.lock
alecps
added a commit
that referenced
this pull request
Aug 30, 2023
* sdks 4.1.1-beta.1, pnpcommon 3.0.0-beta.1 * fix sdk release script and formatting * remove unneccessary combiner dependency * get rid of trx * update signer version used in combiner integration tests * add metering * get rid of trx * highlighting other relevant code for reviewers * highlighting other relevant code for reviewers again * Soloseng/fix-release (#10466) * update packages * change format to number * add back trx * rename tableWithLockForTrx to queryWithOptionalTrx * drive-by remove attestations from config * remove comment * add back trx * add back trx comment * add back rollack * bump version numbers to beta.3 * mock combiner authentication * Odis signer refactor (#10464) Refactors Signer to be more performant * Combiner tracing - staging (#10496) Adds tracing to the combiner * removed blocknumber (#10507) * Signer mock interfaces (#10510) add mock signer interfaces * add moving avg to load test (#10509) * Big Refactor of the combiner (#10513) * first pass into transforming into handlers * Extract methods out of IO class (story: IO class destruction) * io: getSignerEndpoint lifted up to base class * Remove inputChecks and authenticate from IO * wip: kill Combiner and Signer actions * use handler function (remove IO and Action) * kill ThresholdService and ResponseLogger classes * Removes Session and CryptoSession * Fix typing errors * fix tests * Uses httpAgent for http/s connections * use shouldCheckKeyVerion boolean argument * fix some tests * cosmetic cleanup from PR review * Fixes some tests * fix error reporting * fix pnp integration test * bump combiner version * fix integrations test --------- Co-authored-by: alecps <alec@cLabs.co> * fix lint errors * fix unit tests * fix issue on domainQuota signer endpoint * publish common package for combiner deploy * implement AbortSignal any * add back log based metrics * add back trx, fix signer tests * prevent loadtest from crashing on error response (#10517) * Set user agent to the kit (#10518) * Add Remove database error (#10519) * fix log based metric * store signature in requests table (#10520) * store signature in requests table * remove it.only * fix keyVersion parsing * fix fallback url bug * lint fix + bump combiner version * make signature optional * Signer Database requests prunning (#10521) * Signer Database requests prunning * Fix tests * Refactor code * Update packages/phone-number-privacy/signer/src/pnp/services/request-service.ts Co-authored-by: soloseng <102702451+soloseng@users.noreply.github.com> * Adding tests * Update tests * Remove unnecessary transaction wrapper --------- Co-authored-by: soloseng <102702451+soloseng@users.noreply.github.com> * Fixed linter * decrease coverage threshold 76% -> 68% * Add index in timestamp (#10525) * Update packages/phone-number-privacy/signer/src/pnp/services/request-service.ts * fix signer e2e tests * add TODO * fix response metrics * misc cosmetic changes from review * remove unused code from common pkg * misc edits, remove unused test * remove blockNumber from response type schemas * publish common package and bump odis versions * use 4.1.1-dev everywhere except for ODIS packages * revert change to identity sdk * add back change to identity sdk * remove duplicate countAndThrowDBError in domains request table wrapper * misc fixes from reviewing metrics * add TODO statements and remove unused QService * misc cleanup * cleanup combiner comments * remove combiner comment --------- Co-authored-by: soloseng <102702451+soloseng@users.noreply.github.com> Co-authored-by: Mariano Cortesi <mariano@clabs.co> Co-authored-by: Álvaro Fernández <35505302+alvarof2@users.noreply.github.com> Co-authored-by: Gaston Ponti <ponti@clabs.co>
martinvol
added a commit
that referenced
this pull request
Oct 30, 2023
Includes CR10 CI fixes commit 47e5fd8 Author: Aaron DeRuvo <aaron@clabs.co> Date: Fri Oct 20 14:07:23 2023 +0200 Automated Package Publishing (#10661) * configure for snapshot releases * undo mistake of making pkg private commit ddfdd04 Author: Aaron DeRuvo <aaron@clabs.co> Date: Wed Oct 18 15:29:34 2023 +0200 Release Versions (#10656) * beta of next release * privatize packages that we dont publish * yarn install * ignore a few ts errors caused by overly specific types. it is not actually important what type kit is here, only that it has a contracts.getAccount() function on it. the error is related to support for cip64 which has no relevence to the executed code * fix type warnings related to identity/contractkit vs contractkit * beta 2 * Gold Master commit d48c68a Author: Aaron DeRuvo <aaron@clabs.co> Date: Tue Oct 17 11:15:48 2023 +0200 Fast Proposal Viewing (#10652) * speed up viewing of governance proposals by concurrent fetching and some avoided fetches * save chain id to the connection, add contracts from sourcify to the contract mapping * remove console.time * lint * add cs * Bump zod from 3.22.2 to 3.22.4 * Avoid refetching the correct transaction. commit 53bbd49 Author: Aaron DeRuvo <aaron@clabs.co> Date: Mon Oct 16 15:44:53 2023 +0200 add changesets + first set (#10646) * remove old deploy command * fix lock wallet packages commit 177197d Author: Javier Cortejoso <javier.cortejoso@gmail.com> Date: Fri Oct 13 17:28:14 2023 +0200 GitHub Workflow refactor. Run in org-runners (#10649) * GitHub Workflow refactor. Run in org-runners * Remove reference to phone-number-privacy dockerfile * Running pre-protocol-test-release as root * Fix git file permission error * Updated to "stable" runner image commit b102059 Author: Nelson Taveras <4562733+nvtaveras@users.noreply.github.com> Date: Sat Oct 7 14:50:43 2023 -0300 feat: eXOF helm charts, celotool changes and other adhoc fixes (#10626) commit e7ebc92 Author: Aaron DeRuvo <aaron@clabs.co> Date: Mon Oct 2 16:06:40 2023 +0200 REMOVE ODIS/Social Connect (#10640) * removes all files / folders / references to odis /social connect / pnp packages moved to celo-org/social-connect * add in dependencies that were available indirectly. * remove references to phone-number-privacy, identity commit 506ae3b Author: Pastoh <hbandura@users.noreply.github.com> Date: Wed Sep 27 15:52:38 2023 -0300 Update yargs version in celotool (#10312) Update yargs Co-authored-by: Javier Cortejoso <javier.cortejoso@gmail.com> commit 0d1f040 Author: Victoria <4222953+lvpeschke@users.noreply.github.com> Date: Wed Sep 27 18:01:07 2023 +0200 Update circleci.yml (#10631) Ignore Markdown changes when running. commit 27b3406 Author: 0xarthurxyz <46296830+0xarthurxyz@users.noreply.github.com> Date: Wed Sep 27 15:32:03 2023 +0100 Nit: Removes "Draft" from titles in Ethers and Viem migration guides (#10624) commit 1c57785 Author: Nicolas Brugneaux <nicolas.brugneaux@gmail.com> Date: Tue Sep 26 09:50:19 2023 +0200 chore: add migration notes from contractkit (#10228) * chore: add migration notes from contractkit * chore: split into two files * docs: adjust viem docs using stcelo as feedback * chore: remove deprecation note commit 33eb441 Author: Aaron DeRuvo <aaron@clabs.co> Date: Mon Sep 25 11:07:07 2023 +0200 MINOR add cip64 support (#10614) * add cip64 support fix signing test that was supposed to be testing eip1559 dont include fields that are not part of spec in the EncodedTransaction * successfully recover cip64 transactions * add cip64 support dont include fields that are not part of spec in the EncodedTransaction * successfully recover cip64 transactions * while there IS sig here we need to ignore it for the math to check out. commit 5bf6fd6 Author: soloseng <102702451+soloseng@users.noreply.github.com> Date: Fri Sep 22 13:22:15 2023 -0400 ODIS E2E test fix (#10574) * prevent usedQuota from being increased when bypassing quota * make result warning optional * add warning to E2E test commit 5e21031 Author: Aaron DeRuvo <aaron@clabs.co> Date: Fri Sep 22 16:54:34 2023 +0200 EXPLICIT Dependencies (#10615) no dep imported shall be excluded from package.json commit 751976e Author: Aaron DeRuvo <aaron@clabs.co> Date: Thu Sep 21 10:56:30 2023 +0200 Fix Ledger signing (#10599) bump to 5.0.4 and 3.0.1 fix ledger signing commit 0ee42a8 Author: Eric Nakagawa <ericnakagawa@gmail.com> Date: Thu Sep 21 00:39:32 2023 -0700 Update Celo logo in README.md (#10613) commit 1036751 Author: Victoria <4222953+lvpeschke@users.noreply.github.com> Date: Wed Sep 20 19:42:57 2023 +0200 Remove obsolete celotool functionality (#10559) * Remove * Remove Komenci support * Remove celotool support for cluster setup * Remove kong/konga tooling * Remove celotool AWS support * Remove celotool gcp proxy * Remove celotool links * Restore function still in use * Revert "Remove" commit 4b83666 Author: Victoria <4222953+lvpeschke@users.noreply.github.com> Date: Wed Sep 20 18:09:21 2023 +0200 Fix codecov: bare-bones config to get reporting back (#10548) * Add default rules for codecov * Add rule for code removal calculation * Remove mobile flag, no more package for it * Add per packages as components commit f8fac01 Author: Victoria <4222953+lvpeschke@users.noreply.github.com> Date: Wed Sep 20 17:14:04 2023 +0200 Refresh README.md (#10549) - Update build badge to reflect the migration from CircleCI to GitHub Actions - Remove issues badges for categories that are no longer in use - Update docs links commit bd8f74a Author: Aaron DeRuvo <aaron@clabs.co> Date: Wed Sep 20 13:58:59 2023 +0200 celo cli 3 release | no longer include shrinkwrap (#10560) * celo cli 3 beta 2 | no longer include shrinkwrap * update releasing doc * fix src vs lib * 3.0 beta 4 also fix some dep listings * bump to 3.0 * add back dev suffix * dont use git repo use npm package * typo * no git deps! * use published version of @celo/blind-threshhold-bls * Debug * Remove debug * Add git config to use https for ssh git repos * declare module * add missing pkg * dadt * fix mismatch abort controller versions * no implicit imports! * cheeky * declare mod * use v3 of bip39 * revert * how? * another * map blind to celo blind to avoid a conflict (and maybe fix all the errors :) * eyes only * no shh * remove typo space, one bip to rule them all! * no comment --------- Co-authored-by: Javier Cortejoso <javier.cortejoso@gmail.com> Co-authored-by: alvarof2 <fernandez.f.alvaro@gmail.com> commit 5b9fe3f Author: Victoria <4222953+lvpeschke@users.noreply.github.com> Date: Mon Sep 18 19:31:31 2023 +0200 Fix NPM install test (#10569) * Add libudev-dev * Revert to Node 14 commit 0afd1ce Author: soloseng <102702451+soloseng@users.noreply.github.com> Date: Mon Sep 18 11:55:22 2023 -0400 Changed Protocol Test with Coverage Schedule (#10571) changed to every saturday at 13:00 commit 07f25e9 Author: Victoria <4222953+lvpeschke@users.noreply.github.com> Date: Mon Sep 18 16:46:02 2023 +0200 Remove eksportisto charts (#10558) * Remove eksportisto env values * Remove eksportisto from celotool * Remove eksportisto helm charts * Remove eksportisto metric exception commit 4b88542 Author: soloseng <102702451+soloseng@users.noreply.github.com> Date: Thu Sep 14 17:56:16 2023 -0400 switched pnp versions back to dev post sdk release (#10561) * switched pnp versions back to dev post sdk release * bump @types/node version to `^18` * Increased protocol matrix cmd timeout to 40 min commit c15fb93 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Sep 12 15:48:46 2023 +0000 Bump apollo-server-core from 3.12.0 to 3.12.1 (#10532) Bumps [apollo-server-core](https://github.com/apollographql/apollo-server/tree/HEAD/packages/apollo-server-core) from 3.12.0 to 3.12.1. - [Release notes](https://github.com/apollographql/apollo-server/releases) - [Commits](https://github.com/apollographql/apollo-server/commits/apollo-server-core@3.12.1/packages/apollo-server-core) --- updated-dependencies: - dependency-name: apollo-server-core dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 07400b0 Author: Aaron DeRuvo <aaron@clabs.co> Date: Tue Sep 12 16:43:06 2023 +0200 Add support for CIP42 and EIP1559 (#10483) * remove deprecated functions / params for gasPrice / fee currency in kit * improve types / format txs * signing tests, add viem to compare with in tests. * fix type issue, and split the first 12 (not the last 3) * parallelize async calls. * do not extract signer from cip42 txns this doesnt seem to be a very important feature so punting on it to get CK released * update test * revert removal of signer recovery * feedback from sep * add back signer test for faster deving * it works. gandolf rides over the crest as the sun rises blinding the enemy * show error if the rpc caller does not attach * fix binding * lint fix, and remove the call to set FeeMarket (i dont think its actually need as this will happen in tx params normalizer) * cheat and pay with CELO to avoid the ganache issue where when paying in fee token querying for gasPrice give and error due to price lookup having an arg and ganache expecting 0 args * it was never supposed to be like this * why is it gasCurrency here? * add some logging for that bug debug -- dont judge me! * fix but where transfer was not adhering to the gasFeeCurrency flag * fix #10025 js numbers cause impresission * hex must be even * cleanup extra logs / commented out code. * add warning for gatewayfee * add more logging to try to debug test failure * fix test description typos * Dont use custom signing code in protocol test * remove underscore dep * protocol now depends on local wallet * revert back logging to how it was, add back ensure 0x to data if it exists throw an error (like web3 does) if storage key is bad remove temp file for changes (now in PR description) * use named types for address and hex values, mark gateway fee as deprecated fix versioning * publish sdk 5 and pnp-common 3.0.1 * add back dev suffix * use node 18 in container commit 2cc7296 Author: Alec Schaefer <alec@cLabs.co> Date: Mon Sep 11 14:24:01 2023 -0400 odis load test with private key (#10551) * Refactor combiner * Remove combiner timeouts * fix lint * fix combiner e2e tests * point to published dependencies * put auth behind flag * fix config casing * added memory allocation to function * bump version * bump combiner version * switched to dev dependencies * improve signer e2e tests * add mainnet e2e command * add privateKey param to loadTest script * update context name * add private key arg * ++ logging * with new PK * fix addr bug --------- Co-authored-by: Gaston Ponti <ponti@clabs.co> Co-authored-by: soloseng <102702451+soloseng@users.noreply.github.com> commit c4d4791 Author: Alec Schaefer <alec@cLabs.co> Date: Sat Sep 9 10:14:17 2023 -0400 Odis Combiner 3.0.0 Release (#10547) * Refactor combiner * Remove combiner timeouts * fix lint * fix combiner e2e tests * point to published dependencies * put auth behind flag * fix config casing * added memory allocation to function * bump version * bump combiner version * switched to dev dependencies * improve signer e2e tests * add mainnet e2e command * add privateKey param to loadTest script * update context name --------- Co-authored-by: Gaston Ponti <ponti@clabs.co> Co-authored-by: soloseng <102702451+soloseng@users.noreply.github.com> commit 0d433bc Author: Nadiem Sissouno <53600650+sissnad@users.noreply.github.com> Date: Thu Sep 7 15:00:52 2023 +0200 EUROCEUR Oracle Config (#10522) commit 66b1fb3 Author: Gaston Ponti <ponti@clabs.co> Date: Thu Sep 7 00:45:33 2023 -0300 Refactor combiner (#10533) * Refactor combiner * Remove combiner timeouts * fix lint --------- Co-authored-by: Alec Schaefer <alec@cLabs.co> commit 619ae9d Author: Alec Schaefer <alec@cLabs.co> Date: Wed Sep 6 10:24:35 2023 -0400 Odis Signer 3.0.1 (#10543) * Change signer timeout * signer only published dependencies * fix lint error * combiner depends on published versions for CI checks to pass * Catch socket closed event * add logging and metric for closed connection * point back to published dependencies * point dockerfile back to unpublished dependencies * Revert "point dockerfile back to unpublished dependencies" This reverts commit 1eb25eb. * Revert "point back to published dependencies" This reverts commit 3b25f51. * bump version to beta.2 * ∆ to socket.destroyed * ++ debug logging * ++ more logging * ++ abort listeners * reverted to simple connection close * removed extra log * adjust signer version * point back to unpublished dependencies --------- Co-authored-by: Gaston Ponti <ponti@clabs.co> Co-authored-by: soloseng <102702451+soloseng@users.noreply.github.com> commit 0dfd573 Author: Alec Schaefer <alec@cLabs.co> Date: Fri Sep 1 12:23:44 2023 -0400 odis signer release 3.0.0 (#10538) * build signer with only published versions * point combiner to published versions so CI checks pass * add node types to combiner dev dependencies * add node-fetch types to combiner * revert all combiner changes * actually revert all combiner changes * fix node type versions * fix combiner integration tests * fix combiner integration tests, close server before destroying db * revert depending on published dependencies for merge to master, delete unused commands from package.json, bump signer to -dev version * lockfile commit ed9c51b Author: Alec Schaefer <alec@cLabs.co> Date: Thu Aug 31 16:36:58 2023 -0400 sdk release 4.1.1 (#10536) * bump sdk versions to 4.1.1 * bump ODIS common package versions * bump signer and combiner versions * bump versions to 4.1.2-dev * update non-sdk packages to -dev version * update more deps to -dev commit c81e0ff Author: Alec Schaefer <alec@cLabs.co> Date: Wed Aug 30 01:36:46 2023 -0400 ODIS 3.0.0 Release Branch (#10462) * sdks 4.1.1-beta.1, pnpcommon 3.0.0-beta.1 * fix sdk release script and formatting * remove unneccessary combiner dependency * get rid of trx * update signer version used in combiner integration tests * add metering * get rid of trx * highlighting other relevant code for reviewers * highlighting other relevant code for reviewers again * Soloseng/fix-release (#10466) * update packages * change format to number * add back trx * rename tableWithLockForTrx to queryWithOptionalTrx * drive-by remove attestations from config * remove comment * add back trx * add back trx comment * add back rollack * bump version numbers to beta.3 * mock combiner authentication * Odis signer refactor (#10464) Refactors Signer to be more performant * Combiner tracing - staging (#10496) Adds tracing to the combiner * removed blocknumber (#10507) * Signer mock interfaces (#10510) add mock signer interfaces * add moving avg to load test (#10509) * Big Refactor of the combiner (#10513) * first pass into transforming into handlers * Extract methods out of IO class (story: IO class destruction) * io: getSignerEndpoint lifted up to base class * Remove inputChecks and authenticate from IO * wip: kill Combiner and Signer actions * use handler function (remove IO and Action) * kill ThresholdService and ResponseLogger classes * Removes Session and CryptoSession * Fix typing errors * fix tests * Uses httpAgent for http/s connections * use shouldCheckKeyVerion boolean argument * fix some tests * cosmetic cleanup from PR review * Fixes some tests * fix error reporting * fix pnp integration test * bump combiner version * fix integrations test --------- Co-authored-by: alecps <alec@cLabs.co> * fix lint errors * fix unit tests * fix issue on domainQuota signer endpoint * publish common package for combiner deploy * implement AbortSignal any * add back log based metrics * add back trx, fix signer tests * prevent loadtest from crashing on error response (#10517) * Set user agent to the kit (#10518) * Add Remove database error (#10519) * fix log based metric * store signature in requests table (#10520) * store signature in requests table * remove it.only * fix keyVersion parsing * fix fallback url bug * lint fix + bump combiner version * make signature optional * Signer Database requests prunning (#10521) * Signer Database requests prunning * Fix tests * Refactor code * Update packages/phone-number-privacy/signer/src/pnp/services/request-service.ts Co-authored-by: soloseng <102702451+soloseng@users.noreply.github.com> * Adding tests * Update tests * Remove unnecessary transaction wrapper --------- Co-authored-by: soloseng <102702451+soloseng@users.noreply.github.com> * Fixed linter * decrease coverage threshold 76% -> 68% * Add index in timestamp (#10525) * Update packages/phone-number-privacy/signer/src/pnp/services/request-service.ts * fix signer e2e tests * add TODO * fix response metrics * misc cosmetic changes from review * remove unused code from common pkg * misc edits, remove unused test * remove blockNumber from response type schemas * publish common package and bump odis versions * use 4.1.1-dev everywhere except for ODIS packages * revert change to identity sdk * add back change to identity sdk * remove duplicate countAndThrowDBError in domains request table wrapper * misc fixes from reviewing metrics * add TODO statements and remove unused QService * misc cleanup * cleanup combiner comments * remove combiner comment --------- Co-authored-by: soloseng <102702451+soloseng@users.noreply.github.com> Co-authored-by: Mariano Cortesi <mariano@clabs.co> Co-authored-by: Álvaro Fernández <35505302+alvarof2@users.noreply.github.com> Co-authored-by: Gaston Ponti <ponti@clabs.co> commit 84fd807 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Aug 23 22:17:43 2023 +0000 Bump word-wrap from 1.2.3 to 1.2.4 (#10433) Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Victoria <4222953+lvpeschke@users.noreply.github.com> commit 0867b89 Author: pputman-clabs <99900942+pputman-clabs@users.noreply.github.com> Date: Wed Aug 23 14:59:37 2023 -0500 adding trivy option to all the workflows that build containers (#10514) * adding trivy option to all the workflows that build containers * triggering workflow as a test * fixing typo * removing old test workflow that isn't used and removing the workflow trigger for testing trivy commit 76ddc36 Author: soloseng <102702451+soloseng@users.noreply.github.com> Date: Sat Aug 19 15:16:07 2023 -0400 Soloseng/cleanup-legacy-config (#10503) * update pnpcommon README, release sdks script, combiner deps * Update packages/phone-number-privacy/common/README.md Co-authored-by: soloseng <102702451+soloseng@users.noreply.github.com> * Soloseng/firebase-dep-update (#10468) * bump firebase version * format `minInstances` to number * updated peer dependecy * Soloseng/fix-test-quota-bypass (#10471) * enable optional quota bypass during load test. * moved log to better track failed signers * increase the range test sessionID * odis crypto op metering (#10461) add metering * Soloseng/loadtest-with-DEK (#10482) * add option to use DEK in loadtest * Added monitoring counter for AuthenticationMethod * randomized phonenumber to avoid replay attempts * removed ODIS legacy PNP config setters * clean install --------- Co-authored-by: alecps <alec@cLabs.co> commit cffecf9 Author: Edwin <enginebox2012@gmail.com> Date: Wed Aug 16 01:02:35 2023 +0200 Add logic for getTotalPendingWithdrawalsCount (#10488) * Add logic for getTotalPendingWithdrawalsCount * Update contract kit. * Add logic for getPendingWithdrawal. * Remove unneded change. * Update indices. * Add some cases. * Fix version. commit c772fe0 Author: Alec Schaefer <alec@cLabs.co> Date: Tue Aug 15 14:05:52 2023 -0400 update pnpcommon README, fix release sdks script, combiner deps (#10463) update pnpcommon README, release sdks script, combiner deps commit 95d846b Author: Álvaro Fernández <35505302+alvarof2@users.noreply.github.com> Date: Tue Aug 15 03:49:22 2023 +0200 Odis tracing 18 (#10459) * odis-tracing-node18 * yarn command * Test again * Pray * Pray 2 * Pray 3 * Pray 4 * endpoint traces * Error trace * Span in io.ts * Handle errors - OK * Fix if * IO tracing * Common IO tracing * Event messages * Authenticate tracing * Sign tracing * Span end * Span ends * Controller span * NodeTracerProvider * Trace names * Instrumentations * No ExpressInstrumentation * Remove parentSpan * Request * Ignore paths * parentSpan * Ignore more paths * knex instrumentation * Knex instrumentation * Full node inst + manual * ignoreIncomingPaths for http inst * Comments * No cache build * Common packages * TSlint error 1 * TSlint error 2 * TSlint errors * TSlint errors shorthand * // tslint:disable-next-line:no-floating-promises * Fix tests? commit 549a70d Author: Martín Volpe <volpe@clabs.co> Date: Thu Aug 10 14:47:23 2023 +0200 Fix CLI returning zero required votes on proposals with no tx (#10477) Fixed commit bd7a802 Author: nina / ნინა <barbakadzeninaa@gmail.com> Date: Wed Aug 9 13:20:29 2023 +0200 chore: add usdcbrl and usdceur to rc1 config (#10425) commit 3fffa15 Author: Javier Cortejoso <javier.cortejoso@gmail.com> Date: Tue Aug 8 20:44:49 2023 +0200 Dockerfile including whole monorepo (#10472) commit 196ba83 Author: Javier Cortejoso <javier.cortejoso@gmail.com> Date: Fri Aug 4 16:29:16 2023 +0200 Fix proxy startup error (#10465) commit 98dbf1d Author: philbow61 <80156619+philbow61@users.noreply.github.com> Date: Thu Aug 3 11:44:28 2023 +0200 feat: pass fx adapter api keys to oracles (#10443) commit fe5e228 Author: pahor167 <47992132+pahor167@users.noreply.github.com> Date: Wed Aug 2 23:56:49 2023 +0200 Pahor/cli fix2 (#10457) * ReleaseGold refund test fix * gas fix * PR comments * removal of comment * Cli fix 2 commit 6b3decd Author: soloseng <102702451+soloseng@users.noreply.github.com> Date: Wed Aug 2 12:26:27 2023 -0400 ODIS V1 Sunset (#10444) * removed legacy code * ∆ PnpSignAction and PnpQuotaService to non-abstract class * renamed variable * removed empty test * lowered coverage threshold by 3% * add back legacy accounts table for now (#10450) * update sdk/identity * deprecate `endpoint` variable * removed todo comment * removed commented var * increased fetch_depth * increase all fetch_depth * ∆ `pull_request_target` to `pull_request` * bump version * remove endpoint var from call to ODIS * decreased code coverage to threshold to 76% --------- Co-authored-by: Alec Schaefer <alec@cLabs.co> commit 21cdce6 Author: pahor167 <47992132+pahor167@users.noreply.github.com> Date: Wed Aug 2 15:28:01 2023 +0200 ReleaseGold refund test fix (#10440) * ReleaseGold refund test fix * gas fix commit fae4963 Author: Álvaro Fernández <35505302+alvarof2@users.noreply.github.com> Date: Wed Aug 2 11:52:32 2023 +0200 Update circleci.yml action version (#10454) * Update circleci.yml * Remove TODOs comments --------- Co-authored-by: Javier Cortejoso <javier.cortejoso@gmail.com> commit d82d74e Author: soloseng <102702451+soloseng@users.noreply.github.com> Date: Tue Aug 1 11:31:10 2023 -0400 Update monorepo to node 18 (#10274) * Node 18 * update truffle-ganache-ethereumjs dependencies * fix build errors * split migration into JS & TS dir * build with latest node 18.14 * -- ganache.server promise wrapper ∆ ganache.server option format * ignore migrations_ts js files * sync with master * added resolutions * remove lib * removed leftover old dependencies * fixed revert assersion error message * WIP notes * WIP todos * updated web3 & ethereumjs in utils & protocol * ++ ethereum-cryptography dependency * Merge branch 'soloseng/fixing-gas-price' * timeout fix * -- comments * Fixed overflow test * Merge branch 'soloseng/ast-version_fix' * using istanbul hardfork * ++ yarn.lock * update ganache & ethereumjs version * - removed resolutions - using fixed node-fetch types version * built using latest web3 * Updated ganache config * Specify gas and await tx receipt * updated dependencies to fix cross-fecth bind error * updated yarn.lock * updated node version in circleci docker file * updated expected error message * ensure leading 0x instead of trimming * increased jest version * Node 18.16.0 * - update node-fetch - manage migrations folder during build and clean * yarn installed using node 18.16.0 * Appease linter * fixed import issue * use devchain chain copy * using fixed jest version * disabled flake-traker * generated CLI docs * buypass jest_setup in phone-number-privacy/combiner * ignored ts error due to properties mismatch * ++ @types/node-fetch * yarn.lock * using same @types/node-fetch where applicable * ts-ignored for abort-controller * Fix broken kit headers test * temp force exit on contractkit test * no detectOpenHandles * Fix cross-fetch jest mocking issues * lint fix * disabled verbose logs during testing * disabled rpc log in protocol test * Disabled: - pre-protocol-test-release - protocol-test-release * removed disabled jobs from workflow * supress test logs * disabled protocol test * disabling flakey summary * disabled odis test * increased resource class to xlarge * enaled protocol and odis CI test * re-enabled pre-protocol-test-release protocol-test-release * enable phone-number-privacy test logs * Fixing mocha issues in celotool tests * Change node to 18.14.0 * Node 18.14.2 * changed uniswap init code hash * Revert "changed uniswap init code hash" This reverts commit e8a0499. * fix unicode char in datetime format * Update e2e test docker image * verbose output * Pre-review cleanup * appease linter * removed dead code comment cleanup * deprecate defaultRpcCaller for httpRpcCaller This allows compatibility with latest web3 * updated ganache-dev command * appease linter * updated revert assertion with message * downgraded truffle * updated truffle version and config * add web3*@1.8.2 to resolutions * Fixed stability test * removed resolutions * updated yarn lock * updated governance/network test revert messages * updated protocol common test revert assertion msg * appease linter * using assertRevertWithReason in governance/validators * using assertRevertWithReason in governance/voting * angry linter * using assertRevertWithReason in identity/ * fix linter issue * using `@ethereumjs/rlp` for RLP encoding * linter fix * updated web3* dependencies * specify type of transaction * removed verbose output * added `assertRevertWithoutReason()` * linting fix * added revert without msg for identity test * updated deprecated functions * distinguish between transaction reverts and view call reverts * fixed typing ignore * specified gas, as gas estimations fails * updated revert message in test * updated yarn lock * updated yarn lock again * change docker image path * updated revert msg to match contract * updated docs to match current node version * tracking issue in comment * specified chain id * revert to default verbose output * removed debud logging * GH Workflows run in node18 runners * Force new node cache * Disable flake-tracker * prettify * Updated test to revert with message * quiet test * fixed build errors * updated scripts to better handle ts & js files * moved `artifactSingleton` file to lib/ * added transaction type when using mento artifacts * fix Migration test * allow submodules in e2e matrix * python2 -> python (3) * using nvm to switch to node12 for pre-release test * ∆ to trigger GH action * ∆ to trigger full test in GH actions * Using nvm for circleci image * Do not use nvm with circleci * use node12 to generate old release devchain * reset and reinstall before cleaning * set python2 in release branch * installed python2 * added log * removed python2 install script * set new release tag * trigger all test * WIP comments * trigger all test * CircleCi Build pre-protocol with node12 * Circle node12 fix * Adding python 2 and 3 to circleci image * run devchain from tar in detached mode * ++ comments * updated release tag in circleCI config * Replace pull_request by pull_request_target * bump MTWdeployer patch version * testing bypass dryrun * loggin and force CI run * removed false param * revert change and added try catch * moved await * added type to tx detail * included tx type in contract deployment * increased logging level in ganache and truffle * specified gas to deployment tx * removed truffle debug logging * keep chaincopy * removed debug logs * clean up redundant install ++ comment * revert GH action trigger on current branch push * remove comments * remove gas specfication * updated node version in docs * unskip migration test * PR feedback * revert back to skip * ∆ forked packages to celo namespace * reinstalled * cleanup TODO and comments * python -> python3 * updated node base images to 18 * python -> python3 * Updated netcat dependency * Fix build * Fix build docker * force GH action test * removed flake-tracker --------- Co-authored-by: Daniel Kesler <danielckesler@gmail.com> Co-authored-by: Javier Cortejoso <javier.cortejoso@gmail.com> Co-authored-by: Javier Cortejoso <javi@clabs.co> commit e884b03 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Jul 27 19:39:56 2023 +0000 Bump vm2 from 3.9.13 to 3.9.17 (#10276) Bumps [vm2](https://github.com/patriksimek/vm2) from 3.9.13 to 3.9.17. - [Release notes](https://github.com/patriksimek/vm2/releases) - [Changelog](https://github.com/patriksimek/vm2/blob/master/CHANGELOG.md) - [Commits](patriksimek/vm2@3.9.13...3.9.17) --- updated-dependencies: - dependency-name: vm2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Victoria <4222953+lvpeschke@users.noreply.github.com> commit f578337 Author: soloseng <102702451+soloseng@users.noreply.github.com> Date: Wed Jul 26 14:16:41 2023 -0400 Soloseng/set-PNP-default-as-optional-env-var (#10436) * Updates DB timeout to use .env variable. Use constant as fallback * update ODIS to use env var & constants as fallback * increase test timeout * cleanup * lint fix * format * PR comments * forgotten pr feedback * happier linter --------- Co-authored-by: Javier Cortejoso <javier.cortejoso@gmail.com> commit 504732d Author: Javier Cortejoso <javier.cortejoso@gmail.com> Date: Wed Jul 19 18:15:52 2023 +0200 Fix CircleCI status check error when skipping circleci jobs (#10434) * Test error when skipping circleci jobs * Dummy circleci job * Run no-changes always commit 4aa65cd Author: Javier Cortejoso <javier.cortejoso@gmail.com> Date: Wed Jul 19 12:47:58 2023 +0200 CircleCi: Remove automatic execution. Added manual triggers (#10396) commit eafea12 Author: Victoria <4222953+lvpeschke@users.noreply.github.com> Date: Tue Jul 18 13:32:31 2023 +0200 Update stale.yml to v8 (#10429) Update to v8. Significant change: issues get closed as `not planned` as opposed to `completed`. commit 2c59388 Author: Javier Cortejoso <javier.cortejoso@gmail.com> Date: Mon Jul 17 18:47:39 2023 +0200 Remove terraform-modules-public package (#10416) * Remove terraform-modules-public package * Remove terraform library in celotool * remove reference to deleted packages * Update cannonical readme * Updated phone-utils package doc commit 5023851 Author: nina / ნინა <barbakadzeninaa@gmail.com> Date: Tue Jul 11 10:26:38 2023 +0200 chore: remove binanceus from usdc configs (#10422) * chore: remove binanceus from usdc configs * chore: remove bitso and kraken too commit 28ccf04 Author: Karl Bartel <karl.bartel@clabs.co> Date: Mon Jul 10 18:09:26 2023 +0200 Turn Gingerbread off for CIP-35 test (#10398) CIP-35 support is dropped in Gingerbread, so that hard fork must be turned off to test CIP-35. commit 0f2dffb Author: Karl Bartel <karl.bartel@clabs.co> Date: Mon Jul 10 16:48:06 2023 +0200 Update header hash calc in slashing test (#10397) * Using gasLimit in hash if present to make the slasher test work when gasLimit is added to the header in celo-org/celo-blockchain#2062. This function will change again as part of celo-org/celo-blockchain-planning#100. * Use constant header fields in hash if present Related to celo-org/celo-blockchain#2124 * Update header hashing for eth compat Required to support both old headers and Eth-compatible headers. See celo-org/celo-blockchain-planning#100 commit 0ed8544 Author: Javier Cortejoso <javier.cortejoso@gmail.com> Date: Thu Jul 6 10:27:14 2023 +0200 Remove terraform (internal) (#10413) * Removed terraform (non-public) and celotool commands commit 5973c77 Author: Karl Bartel <karl.bartel@clabs.co> Date: Wed Jul 5 16:05:00 2023 +0200 Update yarn.lock (#10414) #10109 did not update the file as expected by CI. Running `yarn install` provided the expected lock file. commit 56a9889 Author: Karl Bartel <karl.bartel@clabs.co> Date: Tue Jul 4 11:57:25 2023 +0200 Check RPC after geth startup to reduce flakiness (#10406) Check RPC after geth startup to reduce flakiness This is meant to avoid the following errors that happens across most (all?) e2e tests from time to time: ``` Error: Connection refused or URL couldn't be resolved: http://localhost:8545 at XMLHttpRequest.request.onreadystatechange (/home/circleci/app/node_modules/web3-providers/dist/web3-providers.cjs.js:759:22) at XMLHttpRequestEventTarget.dispatchEvent (/home/circleci/app/node_modules/xhr2-cookies/xml-http-request-event-target.ts:44:13) at XMLHttpRequest._setReadyState (/home/circleci/app/node_modules/xhr2-cookies/xml-http-request.ts:219:8) at XMLHttpRequest._onHttpRequestError (/home/circleci/app/node_modules/xhr2-cookies/xml-http-request.ts:379:8) at ClientRequest.<anonymous> (/home/circleci/app/node_modules/xhr2-cookies/xml-http-request.ts:266:37) at Socket.socketErrorListener (_http_client.js:406:9) at emitErrorNT (internal/streams/destroy.js:92:8) at emitErrorAndCloseNT (internal/streams/destroy.js:60:3) at processTicksAndRejections (internal/process/task_queues.js:80:21) ``` I am not sure this actually works as intended, but I could not reproduce the problem after this change, anymore. So it is worth testing it out, as we can easily revert the change or improve the approach. commit ec7231d Author: Javier Cortejoso <javier.cortejoso@gmail.com> Date: Fri Jun 30 17:45:49 2023 +0200 Trigger GH jobs when there are changes in packages/sdk (#10377) * Trigger GH jobs when there are changes in packages/sdk * Run all the jobs when pushed to master * Included more test triggers commit f9fde5c Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Jun 29 11:58:14 2023 +0200 Bump knex from 2.1.0 to 2.4.0 (#10109) Bumps [knex](https://github.com/knex/knex) from 2.1.0 to 2.4.0. - [Release notes](https://github.com/knex/knex/releases) - [Changelog](https://github.com/knex/knex/blob/master/CHANGELOG.md) - [Commits](knex/knex@2.1.0...2.4.0) --- updated-dependencies: - dependency-name: knex dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Victoria <4222953+lvpeschke@users.noreply.github.com> commit f1c27e8 Author: Paul Lange <palango@users.noreply.github.com> Date: Tue Jun 20 15:37:48 2023 +0200 Upgrade node-gyp (#10380) * Upgrade gyp * Allow later node-gyp version from 6.0.0 line as well commit 74afbe4 Author: soloseng <102702451+soloseng@users.noreply.github.com> Date: Thu Jun 15 17:30:02 2023 -0400 Changed default PNP timeout to a variable set by env (#10359) * change default timeout to a variable set by env * updated authentication test * PR feedback * fix optinal timout * PR feedback * refactor configs * updated tests commit 4a72b74 Author: soloseng <102702451+soloseng@users.noreply.github.com> Date: Wed Jun 14 10:53:32 2023 -0400 added submodules to gihub action test (#10373) * added submodules to protocol test matrix * format * git submodule checkout in protocol jobs * Fix protocol cache * Rebuild protocol package * Minnor change --------- Co-authored-by: Javier Cortejoso <javier.cortejoso@gmail.com> commit d4a4feb Author: soloseng <102702451+soloseng@users.noreply.github.com> Date: Tue Jun 13 13:09:13 2023 -0400 Updated some protocol matrix test name (#10371) updated github action tests name to match current circleCI test setup commit e208c22 Author: Karl Bartel <karl.bartel@clabs.co> Date: Mon Jun 12 16:06:19 2023 +0200 blockchainparams: remove minimum client version (#10204) * Remove minimum client version set/get/check According to CIP-53: celo-org/celo-proposals#318 * BlockchainParameters: remove ClientVersion In the previous commit, all usage of it has been removed. So now we can remove the state and the initializer params. * Undo remove ClientVersion from BlockchainParameters to keep the storage layout identical. * BlockchainParameters: bump major version We changed the initializer, so the contract API has changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A few sentences describing the overall effects and goals of the pull request's commits.
What is the current behavior, and what is the updated/expected behavior with this PR?
Other changes
Describe any minor or "drive-by" changes here.
Tested
An explanation of how the changes were tested or an explanation as to why they don't need to be.
Related issues
Backwards compatibility
Brief explanation of why these changes are/are not backwards compatible.
Documentation
The set of community facing docs that have been added/modified because of this change