Rewrite of GoVpnAdapter - v055

[hussainmohd-a]

GoVpnAdpater requires a re-write which will be part of v055.
eg., As of now the app fallback on an unmaintained url.

[hussainmohd-a]

"STOP + Failing" or should the app flip to "START + Not protected"?? Line: 521

[ignoramous]

Refs:

ignoramous on 4 Jun
why is this if (in RefreshAsyncTask) required? The invariant that the dns-type is dns-crypt should hold when this block of code is executed. Checking persistentState here, which could have changed in the mean while, is bound to be fraught with race condition.

https://github.com/celzero/rethink-app/pull/282/files/2e87fcfe40433e846d8eb25a309c9d694a4f7911..ff1eb73d3d248914bc282618637af8076c819197#r645636367

---

ignoramous on 4 Jun
I don't get why the persistentState needs to be checked over and over. This task, RefreshOperation should execute under the guise that the current dns-mode is dns-crypt and nothing else.
If race needs to be handled, then checking persistentState in every block of code isn't the way to do it.

hussainmohd-a on 17 Jun
The whole AsyncTast(RefreshOperatio) will be removed witht the upcoming version v055. Will work on the dns mode change with that.

https://github.com/celzero/rethink-app/pull/282/files/2e87fcfe40433e846d8eb25a309c9d694a4f7911..ff1eb73d3d248914bc282618637af8076c819197#r645638373

[ignoramous]

"STOP + Failing" or should the app flip to "START + Not protected"?? Line: 521

Implemented in #282 in BraveVpnService#handleAdapterChange, but it shows failing for now when a tunnel couldn't be established. Re: showing other states (possibly, offline): #294

[ignoramous]

Most of the rewrite is well and truly done.