Connection monitor changes #282

hussainmohd-a · 2021-05-05T20:55:41Z

Setunderlying network logic of v053e is modified.

Now new settings introduced, Set all available networks to the
VPN. If the setting is enabled, the underlying network will be
set with all the available networks. With active network
as first in the list.

If the settings is disabled, only active network will be set in the
underlying network option.

Single threaded handler is implemented to process the messages
from the connectivitiy-manager.

Setunderlying network logic of v053e is modified. Now new settings introduced, Set all available networks to the VPN. If the setting is enabled, the underlying network will be set with all the available networks. With active network as first in the list. If the settings is disabled, only active network will be set in the underlying network option. Single threaded handler is implemented to process the messages from the connectivitiy-manager.

hussainmohd-a · 2021-05-05T20:56:53Z

Already available ConnectionCapabilityMonitor file has been replaced with ConnectionMonitor file.

ignoramous

Rework is required. Please address comments.

app/src/main/java/com/celzero/bravedns/service/ConnectionMonitor.kt

app/src/main/res/values/strings.xml

app/src/main/res/layout/activity_settings_screen.xml

app/src/main/java/com/celzero/bravedns/service/BraveVPNService.kt

app/src/main/java/com/celzero/bravedns/service/ConnectionMonitor.kt

Rename of companion objects - MSG_ADD_ACTIVE_NETWORK, MSG_ADD_ALL_NETWORKS. Removed repeated comments in ConnectionMonitor. Removal of super methods for those where the super method has empty implementation. Cancel all the messages before sending the message from onCapabilitiesChanged and onLinkPropertiesChanged Capture the active network inside handler. Changes on processActiveNetwork() and processAllNetwork()

ignoramous

Please reply to all review comments when done!

app/build.gradle

app/src/main/java/com/celzero/bravedns/service/BraveVPNService.kt

app/src/main/java/com/celzero/bravedns/service/ConnectionMonitor.kt

app/src/main/java/com/celzero/bravedns/ui/HomeScreenActivity.kt

Removed the onUpdateActiveNetwork from the Network Listener. Removed unused constructMessage(message: Message?, what: Int). Made the processMessage into inline. Added logs in processActiveNetwork and processAllNetworks method. Modified the hasInternet and isVPN variables to method.

Added logs for onNetworkDisconnected().

Introduced new settings for the users to select what action button to show in the notification bar. As of now three options provided. 1. No action button. 2. STOP action button. 3. RethinkDNS modes (DNS & DNS+Firewall mode) 1 - No action button will be available in notification bar. 2 - Like earlier, the STOP button will be shown. 3 - DNS and DNS+Firewall mode change - user can change the mode from the action button.

ignoramous

Please improve logging, fix the data-race bug outlined in ConnectionMonitor, and clarify the use of CountDownTimers, which look woefully inefficient at first look, among other changes.

app/src/main/java/com/celzero/bravedns/receiver/NotificationActionReceiver.kt

app/src/main/java/com/celzero/bravedns/service/BraveVPNService.kt

app/src/main/res/values/strings.xml

app/src/main/java/com/celzero/bravedns/ui/SettingsFragment.kt

app/src/main/res/values/strings.xml

app/src/main/java/com/celzero/bravedns/receiver/NotificationActionReceiver.kt

app/src/main/java/com/celzero/bravedns/service/BraveVPNService.kt

Removed usage of Global variable from the Notification receiver. Removed commented out code from VPN service class. Modifications of log statements. ForceUpdate - if onUserPreferenceChanged is changes, the messages should be processed forcefully regardless of the current and new network. Modified and changes on logs and string literals.

app/src/main/java/com/celzero/bravedns/service/BraveVPNService.kt

app/src/main/java/com/celzero/bravedns/util/OrbotHelper.kt

app/src/main/res/values/strings.xml

app/src/main/java/com/celzero/bravedns/ui/SettingsFragment.kt

app/src/main/res/values/strings.xml

app/src/main/java/com/celzero/bravedns/service/ConnectionMonitor.kt

app/src/main/java/com/celzero/bravedns/receiver/NotificationActionReceiver.kt

Instead of raw integers, the constants are used. Changes in logs. Changes in strings literals.

ignoramous

please use Koin where-ever applicable.
please make the changes to ConnectionMonitor to get rid of getNetworkList method and currentActiveNetworks variable, and add a new onVpnStarted method.
add accessor methods to persistent state values that need it, and make sure to hydrate the initial state variables as necessary.
seek to simplify code and reduce clutter.

app/src/main/java/com/celzero/bravedns/receiver/NotificationActionReceiver.kt

app/src/main/java/com/celzero/bravedns/service/BraveVPNService.kt

app/src/main/java/com/celzero/bravedns/util/Constants.kt

app/src/main/res/values/strings.xml

app/src/main/java/com/celzero/bravedns/util/Constants.kt

ConnectionMonitor changes - Removed the method getNetworkList() and introduced new method onVpnStarted(). Moved the currentActiveNetworks to NetworkRequestHandler. Removed the global variable. Rename of constant variables. Change in log statements. Code formatting.

ignoramous · 2021-05-23T10:45:56Z

#277

Kotlin style formatting on some of the files.

app/src/main/java/com/celzero/bravedns/data/AppMode.kt

app/src/main/java/com/celzero/bravedns/receiver/BraveScreenStateReceiver.kt

app/src/main/java/com/celzero/bravedns/receiver/NotificationActionReceiver.kt

app/src/main/java/com/celzero/bravedns/receiver/DeviceLockService.kt

app/src/main/java/com/celzero/bravedns/util/OrbotHelper.kt

app/src/main/res/values/strings.xml

Removed some of the global variables - isBackgroundEnabled. Modified some of the logics in if-else statements where the else statements had just logs. Remove some raw int's. Notification in case of failure loading the firewall rules. Notification action button color now depends on system theme. Changes in check for the background accessibility. Changes in the logger statements. Changes in the comments. Changes in logic of handling network connections. Adding the network request count every one minute to shared-pref.

Update new-line in ConnectionMonitor.

hussainmohd-a

Removed some of the global variables -isBackgroundEnabled.
Modified some of the logics in if-else statements where the else statements had just logs.
Remove some raw int's.
Notification in case of failure loading the firewall rules.
Notification action button color now depends on system theme.
Changes in check for the background accessibility.
Changes in the logger statements.
Changes in the comments.
Changes in logic of handling network connections.
Adding the network request count every one minute to shared-pref.

Port 853 reserved port name change from "domain-s" to "secure-dns".

According to the documentation, the establish function will return null if the VpnService has not been prepared, however we are using prepare() prior to establish(). Some cases, the ParcelFileDescriptor is null. This results the app in the red waiting state during the vpn restart. Fix will stop the vpn complete in case if the builder.establish() returned as null. Move the code - open the vpn profile to a common place. (called from both Home screen and about page).

app/src/main/java/com/celzero/bravedns/receiver/DeviceLockService.kt

app/src/main/java/com/celzero/bravedns/receiver/NotificationActionReceiver.kt

app/src/main/java/com/celzero/bravedns/ui/HomeScreenFragment.kt

app/src/main/java/com/celzero/bravedns/ui/SettingsFragment.kt

app/src/main/java/com/celzero/bravedns/receiver/BraveScreenStateReceiver.kt

ignoramous

Cosmetic comments, mostly.

Changes / addition of new comments. Rename of methods and variables. Code-abstract. Code-format. New check for active notification for load failure.

Code formatting. Issue fix for failure to load image for the applications and category in Firewall app fragment.

app/src/main/java/com/celzero/bravedns/download/FileHandleWorker.kt

app/src/main/java/com/celzero/bravedns/ui/DNSLogFragment.kt

app/src/main/java/com/celzero/bravedns/ui/ExcludeAppDialog.kt

Code refractor. Changes in log statements. Changes in error handling. Removed unwanted code comments. Changes in code comments. Changes in variable or method names.

Notification now launches Firewall activity instead of default launcher activity. Removed unused code.

Code refractor. Changes in log statements. Removed unwanted code comments. Changes in code comments. Changes in variable or method names.

ignoramous

Almost home.

app/src/main/java/com/celzero/bravedns/adapter/ConnectionTrackerAdapter.kt

app/src/main/java/com/celzero/bravedns/NonStoreAppUpdater.kt

app/src/main/java/com/celzero/bravedns/receiver/NotificationActionReceiver.kt

app/src/main/java/com/celzero/bravedns/ui/ConnTrackerBottomSheetFragment.kt

hussainmohd-a requested a review from ignoramous May 5, 2021 21:00

ignoramous reviewed May 6, 2021

View reviewed changes

ignoramous reviewed May 12, 2021

View reviewed changes

hussainmohd-a added 3 commits May 16, 2021 01:14

Added logs

d98e06c

Added logs for onNetworkDisconnected().

ignoramous reviewed May 17, 2021

View reviewed changes

ignoramous reviewed May 18, 2021

View reviewed changes

ignoramous reviewed May 19, 2021

View reviewed changes

app/src/main/java/com/celzero/bravedns/service/ConnectionMonitor.kt Outdated Show resolved Hide resolved

ignoramous reviewed May 19, 2021

View reviewed changes

app/src/main/java/com/celzero/bravedns/receiver/NotificationActionReceiver.kt Outdated Show resolved Hide resolved

Remove raw integers

b5f88d3

Instead of raw integers, the constants are used. Changes in logs. Changes in strings literals.

ignoramous reviewed May 22, 2021

View reviewed changes

hussainmohd-a requested a review from ignoramous May 23, 2021 15:28

Code formatting

27e58dc

Kotlin style formatting on some of the files.

ignoramous reviewed May 24, 2021

View reviewed changes

hussainmohd-a added 2 commits May 28, 2021 05:30

Update new line

a6ad26a

Update new-line in ConnectionMonitor.

hussainmohd-a commented May 28, 2021

View reviewed changes

hussainmohd-a added 2 commits May 30, 2021 10:25

Reserved Port 853 - service name change

1a471d7

Port 853 reserved port name change from "domain-s" to "secure-dns".

ignoramous reviewed Jun 2, 2021

View reviewed changes

Constants, comments changes, code abstract

12dcb01

Changes / addition of new comments. Rename of methods and variables. Code-abstract. Code-format. New check for active notification for load failure.

Code formatting, bug fix

2e87fcf

Code formatting. Issue fix for failure to load image for the applications and category in Firewall app fragment.

hussainmohd-a requested a review from ignoramous July 8, 2021 15:42

hussainmohd-a mentioned this pull request Jul 9, 2021

Revisit Room for possible index creation. #330

Closed

ignoramous reviewed Jul 12, 2021

View reviewed changes

ignoramous reviewed Jul 19, 2021

View reviewed changes

app/src/main/java/com/celzero/bravedns/ui/ExcludeAppDialog.kt Outdated Show resolved Hide resolved

hussainmohd-a added 2 commits July 21, 2021 01:03

Code refractor, log changes, variable rename

baa0ae2

Code refractor. Changes in log statements. Changes in error handling. Removed unwanted code comments. Changes in code comments. Changes in variable or method names.

App not in use notification change

ff1eb73

Notification now launches Firewall activity instead of default launcher activity. Removed unused code.

Code refractor, variable/method rename

52d798d

Code refractor. Changes in log statements. Removed unwanted code comments. Changes in code comments. Changes in variable or method names.

ignoramous reviewed Jul 31, 2021

View reviewed changes

Merge branch 'master' into v053f

632a3d1

ignoramous merged commit 5cdea0b into master Jul 31, 2021

ignoramous mentioned this pull request Aug 1, 2021

Internet connectivity issues #277

Closed

ignoramous mentioned this pull request Aug 14, 2021

RethinkDNS Plus quite often switches back to RethinkDNS Basic (default) #170

Closed

ignoramous mentioned this pull request Aug 25, 2021

v053f missing from Github releases & F-Droid #359

Closed

This was referenced Sep 1, 2021

CPBL: Final list displays incorrectly in log view #362

Closed

Eval extensive use of GlobalScope coroutines #243

Closed

Remove the AppMode global #200

Closed

User feedback: DNS Stats #42

Open

ignoramous mentioned this pull request May 19, 2023

Fine tuning app instead of adding buggy features #911

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Connection monitor changes #282

Connection monitor changes #282

hussainmohd-a commented May 5, 2021

hussainmohd-a commented May 5, 2021

ignoramous left a comment

ignoramous left a comment

ignoramous left a comment

ignoramous left a comment

ignoramous commented May 23, 2021

hussainmohd-a left a comment

ignoramous left a comment

ignoramous left a comment

Connection monitor changes #282

Connection monitor changes #282

Conversation

hussainmohd-a commented May 5, 2021

hussainmohd-a commented May 5, 2021

ignoramous left a comment

Choose a reason for hiding this comment

ignoramous left a comment

Choose a reason for hiding this comment

ignoramous left a comment

Choose a reason for hiding this comment

ignoramous left a comment

Choose a reason for hiding this comment

ignoramous commented May 23, 2021

hussainmohd-a left a comment

Choose a reason for hiding this comment

ignoramous left a comment

Choose a reason for hiding this comment

ignoramous left a comment

Choose a reason for hiding this comment