Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MK8] clean up and New Mods #661

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

intra0
Copy link
Contributor

@intra0 intra0 commented Dec 14, 2024

adds v1 support to 60fps and resolution pack
adds the credits comment to every pack
adds bloom pack from M&&M's v5 repository

Adds 7 new save file cheat mods

adds v1 support to 60fps and resolution pack
adds new course unlock pack and vehicle unlock pack
@intra0
Copy link
Contributor Author

intra0 commented Dec 14, 2024

Oh, @ActualMandM in your repository you have a FXAA mod for MK8?
https://github.com/ActualMandM/gfx_pack/blob/master/src/MarioKart8/Enhancements/FXAA/rules.txt

this is the only mod in your repository I dont know what to do with
the Anti-aliasing stuff in the graphics mod is called FXAA, and the graphics mod removes AA, but I read that MK8 doesn't have AA, and basically I am just very confused about the state of anti-aliasing in Mario Kart 8

Do you think your MK8 FXAA pack should be updated to v6/7 and added, and if so would there need to be any changes to the current resolution mod or?? basically whats the deal with airplane food Mario Kart Anti-Aliasing?

.
.
Every other mod in your repository I have already updated to v6/7 and will slowly be merging with this main repository
so thanks for the help

@ActualMandM
Copy link
Contributor

MK8 does use FXAA, but only on character select. IIRC the main graphic pack patches the code to also apply when in a race, so the pack from that repo is redundant

@ActualMandM
Copy link
Contributor

Oops, turns out the code in the main pack is for disabling FXAA in character select instead, sorry for misremembering

Anyways the pack is a post processing effect. It's been a while since I've really looked much into packs so this is more a question for @Crementif or the original pack creator @getdls

@intra0 intra0 changed the title [MK8] clean up and added v1 support [MK8] clean up and New Mods Dec 14, 2024
titleIds = 000500001010EC00,000500001010ED00,000500001010EB00
name = Gold Trophy / 3 stars
path = "Mario Kart 8/Cheats/Grand Prix Trophies"
description = Cheat in Grand Prix Trohpies!|Must complete or quit a Grand Prix to save changes.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have a better sugestion for the Must complete or quit a Grand Prix to save changes. line
or Better names for Change EVERYTHING (200/mirror/150/100/50) Change Entire Engine Class Change Specific Cup (activates by cursor moving onto 50cc)
please let me know. I think they're fine but feels like they could be worded better

to be consistent with other mods
It only hid 3 categories
made the mod harder to use (imo)
and if someone doesn't know what to do with an option there's a (Default) that already serves the purpose of them just not messing with the setting
@getdls
Copy link
Collaborator

getdls commented Dec 18, 2024

I could have sworn the patch AA to in-game was working and thats why we nuked FXAA??
The FXAA pack was mostly a copy-paste from XCX with really low settings to avoid the smearing, while still fixing some of the worst specular edge aliasing.

@intra0
Copy link
Contributor Author

intra0 commented Dec 18, 2024

@getdls tested it and could see no difference between having it enabled vs disabled.
Was using OpenGL

@getdls
Copy link
Collaborator

getdls commented Dec 18, 2024

Thnx, for checking.. and good work on the other stuff
Mandela effect I guess :/ Trust, but verify! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants