fix: correctly set HTTP headers on outgoing requests. (#69)

settings options.headers does not directly update the headers, setHeader ensures the modifications make it to the actual request.
census-instrumentation · Jun 29, 2018 · 58d23f5 · 58d23f5
1 parent e5222c4
commit 58d23f5
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/packages/opencensus-instrumentation-http/src/http.ts b/packages/opencensus-instrumentation-http/src/http.ts
@@ -256,10 +256,9 @@ export class HttpPlugin extends BasePlugin {
     return (span: Span): httpModule.ClientRequest => {
       plugin.logger.debug('makeRequestTrace');
 
-      const headers = options.headers;
       const setter: HeaderSetter = {
         setHeader(name: string, value: string) {
-          headers[name] = value;
+          request.setHeader(name, value);
         }
       };
 
@@ -280,6 +279,7 @@ export class HttpPlugin extends BasePlugin {
         response.on('end', () => {
           plugin.logger.debug('outgoingRequest on end()');
           const method = response.method ? response.method : 'GET';
+          const headers = options.headers;
           const userAgent =
               headers ? (headers['user-agent'] || headers['User-Agent']) : null;