Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

correctly set HTTP headers on outgoing requests. #69

Merged
merged 1 commit into from
Jun 29, 2018

Conversation

tcolgate
Copy link
Contributor

No description provided.

settings options.headers does not directly update the headers,
setHeader ensures the modifications make it to the actual request.
@tcolgate tcolgate changed the title Fix for non-null parentSpanId correctly set HTTP headers on outgoing requests. Jun 29, 2018
Copy link
Contributor

@kjin kjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch!

@kjin kjin merged commit 58d23f5 into census-instrumentation:master Jun 29, 2018
kjin pushed a commit to kjin/opencensus-node that referenced this pull request Aug 24, 2018
…entation#69)

settings options.headers does not directly update the headers,
setHeader ensures the modifications make it to the actual request.
kjin pushed a commit to kjin/opencensus-node that referenced this pull request Aug 24, 2018
…entation#69)

settings options.headers does not directly update the headers,
setHeader ensures the modifications make it to the actual request.
kjin pushed a commit to kjin/opencensus-node that referenced this pull request Aug 24, 2018
…entation#69)

settings options.headers does not directly update the headers,
setHeader ensures the modifications make it to the actual request.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants