Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v5 schema #72

Merged
merged 2 commits into from
Apr 29, 2023
Merged

Update to v5 schema #72

merged 2 commits into from
Apr 29, 2023

Conversation

roysc
Copy link
Collaborator

@roysc roysc commented Apr 24, 2023

Basic refactor and CI update

Copy link
Collaborator

@i-norden i-norden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm something is wrong in CI, log messages aren't particularly helpful. Looks like docker is having issues with the "migrations" image (ipld-eth-db). The v5.0.0-alpha version should work but we should change it to v5.0.1-alpha anyways.

@roysc roysc requested a review from i-norden April 25, 2023 08:39
@roysc
Copy link
Collaborator Author

roysc commented Apr 25, 2023

Shall we also tag this as v5.0.1-alpha?

@i-norden
Copy link
Collaborator

i-norden commented Apr 26, 2023

@roysc we should tag this v5.0.0-alpha.

The convention we use for any repo that depends on ipld-eth-db is that its major version should correspond to the major version of the version of ipld-eth-db that it works with. The minor and patch versions float independently for each repo, so that you can make changes to those codebases that don't require changing the version of ipld-eth-db being used. Likewise, changes to ipld-eth-db which don't break backwards compatibility with dependent repos should bump the minor or patch versions and any schema change that breaks backwards compatibility should be a major version change.

@roysc roysc merged commit f09675a into v5 Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants