Update to geth 1.11.5-statediff-v5 #238
Conversation
…or the separation of concerns was because we used to fetch cids directly from the database but then use those to fetch iplds using an ipfs.BlockService abstraction ontop of our database (and/or a ipfs.BlockExchange). But now they are both accessed directly in the local DB. Additionally, some of the queries should be further refined/refactored/combined as we no longer need to take two trips but can retrieve cid and ipld in the same query.
… over there in v5
v5 Checkpoint
…new get_storage_at_by_hash func)
roysc
force-pushed
the
roy/v5-dev
branch
5 times, most recently
from
53dee38 to
da578d6
Compare
Now uses: * ipld direct_by_leaf StateDB for basic queries * trie_by_cid StateDB for trie slice and proof queries Also: * vulcanize => cerc refactor * Backend method to close dbs * state tests are in multiple packages, to allow separate ginkgo suites * removes gap-filler module * integration tests and github workflows * run stack-orchestrator for testnet * fix various issues with tests, hardhat server, dockerfile * fix cmd flags / env vars * fix flaky tests and clean up code * remove unused code, scripts * remove outdated docs * update version
There was a problem hiding this comment.
Looks great, this represents a tremendous amount of work. I've reviewed this line for line and haven't caught anything to fix. In the future we can consider if it is possible to break these major upgrades up into smaller pieces of work for PRs, but I am doubtful it is feasible to do so in such a way where the intermediate states have passing tests..
|
Actually just a few nitpicks: Lets remove https://github.com/cerc-io/ipld-eth-server/blob/roy/v5-dev/environments/subscribeExample.toml |
roysc
force-pushed
the
roy/v5-dev
branch
2 times, most recently
from
50cd76b to
911b0ed
Compare
fix: `err` overshadowing in `defer`s
An extensive refactor to update Geth interfaces and update for compatibility with the v5 schema.
Depends on:
gap-filler-we need to confirm if we can deprecate and remove it (Either archive me or transfer me to cerc-io vulcanize/gap-filler#11) or bring into cerc (in which case I will wait until that's done to open a PR)removed