Fixes and refactors for use in ipld-eth-server #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetState takes a slot, not a leaf path
used in ipld-eth-server
* direct_by_leaf/ is original StateDB package * sql/ for SQL DB interfaces
was erroneously storing the cid in the fullNode's flag.cache
i-norden
approved these changes
Apr 25, 2023
There was a problem hiding this comment.
LGTM! I like the reorganization 👍
Don't see a change for
- fix
direct_by_leaf.StateDB.GetStateto take a storage slot (preimage of leaf key) as argument
And not sure that would make sense because in the db the records are indexed by leaf key and the processes above that will call down into the StateDB will also be hash-aware not preimage-aware.
|
@i-norden that's this one: e3e4e1e The slot key is passed in when executing a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few things detected while integrating into ipld-eth-server for v5:
direct_by_leaf.StateDB.GetStateto take a storage slot (preimage of leaf key) as argumentAlso, refactors into sub-packages so we now have
direct_by_leaf- original StateDB packagetrie_by_cidsqlfor SQL DB utilAnd, DRYs up the tests and adds some basic trie tests.