set namespace from values.yaml #287
Conversation
Signed-off-by: Andres Vara <46708607+andres-vara@users.noreply.github.com>
Signed-off-by: Andres Vara <46708607+andres-vara@users.noreply.github.com>
andres-vara
force-pushed
the
default-namespace
branch
from
dc09caf
to
497eaf8
Compare
|
/assign @jakexks |
Signed-off-by: Andres Vara <46708607+andres-vara@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Andres Vara <46708607+andres-vara@users.noreply.github.com>
| @@ -2,5 +2,5 @@ apiVersion: v2 | |||
| name: aws-privateca-issuer | |||
| description: An addon for cert-manager to sign certificates using AWS PCA | |||
| type: application | |||
| version: v1.2.5 | |||
There was a problem hiding this comment.
This version bump is for when we want to cut a new release. Let's keep this at 1.2.5 for now
Signed-off-by: Andres Vara <46708607+andres-vara@users.noreply.github.com>
Signed-off-by: Andres Vara <46708607+andres-vara@users.noreply.github.com>
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Currently, there is no option to define a namespace to deploy, the ".Release.Namespace" is used as the hardcoded value.
This pull request enables users to specify a namespace. If not specified, the default namespace ".Release.Namespace" is used.