Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set namespace from values.yaml #287

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

set namespace from values.yaml #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
55b0483
added default namespace
andres-vara Sep 23, 2023
497eaf8
added comment
andres-vara Sep 23, 2023
b97d3da
add missed ns change
andres-vara Sep 26, 2023
3b675f0
bumped version
andres-vara Oct 2, 2023
def0789
removed bin
andres-vara Oct 2, 2023
e650146
revert back version
andres-vara Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/aws-pca-issuer/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ name: aws-privateca-issuer
description: An addon for cert-manager to sign certificates using AWS PCA
type: application
version: v1.2.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version bump is for when we want to cut a new release. Let's keep this at 1.2.5 for now

appVersion: v1.2.5
appVersion: v1.2.6
2 changes: 1 addition & 1 deletion charts/aws-pca-issuer/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: apps/v1
kind: Deployment
metadata:
name: {{ include "aws-privateca-issuer.fullname" . }}
namespace: {{ .Release.Namespace }}
namespace: {{ default .Release.Namespace .Values.namespace }}
labels:
{{- include "aws-privateca-issuer.labels" . | nindent 4 }}
spec:
Expand Down
2 changes: 1 addition & 1 deletion charts/aws-pca-issuer/templates/hpa.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: autoscaling/v2beta1
kind: HorizontalPodAutoscaler
metadata:
name: {{ include "aws-privateca-issuer.fullname" . }}
namespace: {{ .Release.Namespace }}
namespace: {{ default .Release.Namespace .Values.namespace }}
labels:
{{- include "aws-privateca-issuer.labels" . | nindent 4 }}
spec:
Expand Down
2 changes: 1 addition & 1 deletion charts/aws-pca-issuer/templates/pdb.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: policy/v1
kind: PodDisruptionBudget
metadata:
name: {{ include "aws-privateca-issuer.fullname" . }}
namespace: {{ .Release.Namespace }}
namespace: {{ default .Release.Namespace .Values.namespace }}
labels:
{{- include "aws-privateca-issuer.labels" . | nindent 4 }}
spec:
Expand Down
4 changes: 2 additions & 2 deletions charts/aws-pca-issuer/templates/rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: v1
kind: ServiceAccount
metadata:
name: {{ include "aws-privateca-issuer.serviceAccountName" . }}
namespace: {{ .Release.Namespace }}
namespace: {{ default .Release.Namespace .Values.namespace }}
labels:
{{- include "aws-privateca-issuer.labels" . | nindent 4 }}
{{- with .Values.serviceAccount.annotations }}
Expand Down Expand Up @@ -132,7 +132,7 @@ roleRef:
subjects:
- kind: ServiceAccount
name: {{ include "aws-privateca-issuer.serviceAccountName" . }}
namespace: {{ .Release.Namespace }}
namespace: {{ default .Release.Namespace .Values.namespace }}
---
{{- end }}
{{- if .Values.approverRole.enabled -}}
Expand Down
2 changes: 1 addition & 1 deletion charts/aws-pca-issuer/templates/service-monitor.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
name: {{ include "aws-privateca-issuer.fullname" . }}
namespace: {{ .Release.Namespace }}
namespace: {{ default .Release.Namespace .Values.namespace }}
labels:
{{- include "aws-privateca-issuer.labels" . | nindent 4 }}
{{- with .Values.serviceMonitor.annotations }}
Expand Down
2 changes: 1 addition & 1 deletion charts/aws-pca-issuer/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v1
kind: Service
metadata:
name: {{ include "aws-privateca-issuer.fullname" . }}
namespace: {{ .Release.Namespace }}
namespace: {{ default .Release.Namespace .Values.namespace }}
labels:
{{- include "aws-privateca-issuer.labels" . | nindent 4 }}
spec:
Expand Down
3 changes: 3 additions & 0 deletions charts/aws-pca-issuer/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ imagePullSecrets: []
nameOverride: ""
fullnameOverride: ""

# if namespace is not set the .Release.Namespace will be used as default.
namespace: ""

revisionHistoryLimit: 10

serviceAccount:
Expand Down