Rework Plot Axes #479
Merged
Rework Plot Axes #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannes-wolf
force-pushed
the
cetz-328-plot-axis-configuration
branch
8 times, most recently
from
b51873c
to
669fc82
Compare
johannes-wolf
force-pushed
the
cetz-328-plot-axis-configuration
branch
2 times, most recently
from
8877540
to
eb68e4e
Compare
johannes-wolf
force-pushed
the
cetz-328-plot-axis-configuration
branch
from
d1d91a3
to
a850be9
Compare
This was
linked to
issues
Jan 31, 2024
fenjalien
requested changes
Feb 1, 2024
No, I am not yet happy but would like to do further changes later. |
johannes-wolf
force-pushed
the
cetz-328-plot-axis-configuration
branch
from
db42490
to
f9df042
Compare
johannes-wolf
force-pushed
the
cetz-328-plot-axis-configuration
branch
from
f9df042
to
bb836c8
Compare
johannes-wolf
added a commit
that referenced
this pull request
Feb 11, 2024
Allows passing `none` or `ctx => {}` to grouping functions (`group`,
`on-layer`, ...).
This is very useful when having conditional draw commands insides a
group.
Example:
```
group(ctx => {
if .. {
// If this does not get evaluated, cetz currently fails because the group returned `none`.
// Current workaround is writing () at the end of such groups to auto-join an empty array.
}
})
```
This PR is an improved implementation of the one rejected from #479.
johannes-wolf
force-pushed
the
cetz-328-plot-axis-configuration
branch
from
bb836c8
to
bb8aa8c
Compare
fenjalien
approved these changes
Feb 14, 2024
johannes-wolf
force-pushed
the
cetz-328-plot-axis-configuration
branch
3 times, most recently
from
fde49a9
to
3b1b913
Compare
johannes-wolf
force-pushed
the
cetz-328-plot-axis-configuration
branch
from
3b1b913
to
905b603
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleanup of the axis drawing code. More refactoring should follow, but in a follow-up PR.
Axis styling documentation is not good yet!
New features:
I am not happy with the shared "0" tick drawing, this should get improved!