Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aln2counts_simplify tool #1023

Merged
merged 8 commits into from
Oct 16, 2023
Merged

Add aln2counts_simplify tool #1023

merged 8 commits into from
Oct 16, 2023

Conversation

Donaim
Copy link
Member

@Donaim Donaim commented Oct 11, 2023

This is similar to denovo_simplify,
but only runs the postprocessing part.

This is similar to denovo_simplify,
but only runs the postprocessing part.
@Donaim Donaim requested a review from donkirkby October 11, 2023 19:19
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3f791c5) 86.43% compared to head (89bc579) 86.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1023   +/-   ##
=======================================
  Coverage   86.43%   86.43%           
=======================================
  Files          28       28           
  Lines        6110     6110           
=======================================
  Hits         5281     5281           
  Misses        829      829           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Donaim Donaim marked this pull request as ready for review October 11, 2023 20:37
Copy link
Member

@donkirkby donkirkby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two very minor suggestions, but it looks good to me.

Does it work?

micall/utils/aln2counts_simplify.py Outdated Show resolved Hide resolved
micall/utils/aln2counts_simplify.py Outdated Show resolved Hide resolved
@Donaim
Copy link
Member Author

Donaim commented Oct 11, 2023

@donkirkby It worked for a smaller example, but I have not yet confirmed it for a bigger test.
The final version of stitched.csv does not seem to contain the searched sequence, even though I am directly asserting that it does in the test.
Maybe it's because that final version is supposed to fail the test actually.

@Donaim
Copy link
Member Author

Donaim commented Oct 11, 2023

Update: it works. @donkirkby

Copy link
Member

@donkirkby donkirkby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor simplifications to consider.

micall/utils/aln2counts_simplify.py Outdated Show resolved Hide resolved
micall/utils/aln2counts_simplify.py Show resolved Hide resolved
Co-authored-by: Don Kirkby <donkirkby@users.noreply.github.com>
@donkirkby donkirkby merged commit d7ba0d8 into master Oct 16, 2023
3 checks passed
@donkirkby donkirkby deleted the aln2counts-dd branch October 16, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants