-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aln2counts_simplify tool #1023
Conversation
This is similar to denovo_simplify, but only runs the postprocessing part.
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1023 +/- ##
=======================================
Coverage 86.43% 86.43%
=======================================
Files 28 28
Lines 6110 6110
=======================================
Hits 5281 5281
Misses 829 829 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two very minor suggestions, but it looks good to me.
Does it work?
@donkirkby It worked for a smaller example, but I have not yet confirmed it for a bigger test. |
Update: it works. @donkirkby |
Co-authored-by: Don Kirkby <donkirkby@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor simplifications to consider.
Co-authored-by: Don Kirkby <donkirkby@users.noreply.github.com>
This is similar to denovo_simplify,
but only runs the postprocessing part.