Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore case of runParameters.xml #25

Closed
donkirkby opened this issue Sep 9, 2015 · 3 comments
Closed

Ignore case of runParameters.xml #25

donkirkby opened this issue Sep 9, 2015 · 3 comments
Assignees
@rmcclosk
Labels
enhancement
Milestone
near future

Comments

@donkirkby
Copy link
Member

The data from the CDC Miseq uses the name RunParameters.xml instead of runParameters.xml, and that causes the QC upload to fail. Our Miseq will be upgraded soon, so it will probably be a problem for our data as well.

Just check for both possible names when uploading.
@donkirkby donkirkby added this to the near future milestone Sep 9, 2015
@rmcclosk
Copy link
Contributor

@donkirkby Is this the one you wanted me to look into?

@donkirkby
Copy link
Member Author

Yes please, @rmcclosk.

@rmcclosk rmcclosk self-assigned this Sep 10, 2015
@rmcclosk
Copy link
Contributor

Would you rather it be uploaded as runParameters.xml, or with the same name as it had coming in?

Edit: never mind, dumb question. We don't actually upload the file.

rmcclosk added a commit that referenced this issue Sep 10, 2015
@rmcclosk
Tolerate upper case "R" in "RunParameters.xml".
3f328e8 
See issue #25.
@rmcclosk rmcclosk mentioned this issue Sep 10, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmcclosk rmcclosk

Labels
enhancement
Projects
None yet
Milestone
near future
Development

No branches or pull requests
2 participants
@rmcclosk @donkirkby