Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wagtail-footnotes to fix footnote ordering #8610

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Conversation

willbarton
Copy link
Member

This PR updates wagtail-footnotes to 0.13.0, which includes our fix for footnote ordering. It makes two changes to footnotes admin UX:

  • Fixes a bug where footnotes could change how they're ordered in the admin for content editors between adding footnotes and saving the draft with the new footnotes.
  • Makes it possible for content editors to reorder footnotes in the admin just like any other Wagtail content element.

Neither of these ordering problems had any impact on the final rendered page — rendered footnotes are always numbered and ordered in the the order they are referenced in content.

See GHE/Design-Development/Design-and-Content-Team/issues/545 and torchbox/wagtail-footnotes#75 for more context.

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)

@willbarton willbarton added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit 47cbf8a Oct 21, 2024
12 checks passed
@willbarton willbarton deleted the update/footnotes branch October 21, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants