Make footnotes orderable #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than a potentially random order, that changes from initial draft after save, allow a content editor to change the ordering of footnotes in the editor by making them inherit from `wagtail.models.Orderable`.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our content editors are finding that the footnotes list in the Wagtail editor page changes order on them after saving a batch of footnotes. This creates some UX headaches (along with the fact that Wagtail gives InlinePanels an automatic index number, which creates confusion in the context of footnotes).
This small change makes the
Footnotemodel inherit fromwagtail.models.Orderable. This has the dual effect of preserving add-order of the footnotes for each page, and allowing a content editor to move them around as needed, ensuring that footnotes are always listed in a predictable, user-changeable, order in both the footnote selector and at in the page editor.