Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build safari extension #7

Open
chadian opened this issue Jan 15, 2022 · 3 comments · May be fixed by #8
Open

Build safari extension #7

chadian opened this issue Jan 15, 2022 · 3 comments · May be fixed by #8
Labels
enhancement New feature or request

Comments

@chadian
Copy link
Owner

chadian commented Jan 15, 2022

It looks like migrating to a safari supported browser extension might be relatively easy. It also depends on whether the same APIs and permissions are provided for storage.
@chadian
Copy link
Owner Author

chadian commented Feb 7, 2022

Gave this a go and from a test build from Xcode there were no issues, it just worked ™️. I'll need to also see if it's possible for it to work with safari on iOS.

image

@chadian
Copy link
Owner Author

chadian commented Feb 7, 2022

It works on iOS, too. It'll need some design tweaks but it appears all the functionality is there.

@chadian chadian linked a pull request Feb 9, 2022 that will close this issue
Open
3 tasks
@chadian chadian added the enhancement New feature or request label Oct 2, 2022
chadian added a commit that referenced this issue Oct 16, 2022
@chadian
Migrate image resizing to be background service worker compatiable
807073a 
Using OffscreenCanvas is not supported by Safari, and currently
there's no obvious way of resizing images in a web worker in Safari
without passing the work back to the main extension thread.

Currently, Safari is not supported but there are plans to support
it in the future, see #7 and #8.
chadian added a commit that referenced this issue Oct 16, 2022
@chadian
Migrate image resizing to be background service worker compatiable
39aca59 
Using OffscreenCanvas is not supported by Safari, and currently
there's no obvious way of resizing images in a web worker in Safari
without passing the work back to the main extension thread.

Currently, Safari is not supported but there are plans to support
it in the future, see #7 and #8.
@chadian chadian mentioned this issue Oct 17, 2022
Draft
2 tasks
@chadian
Copy link
Owner Author

chadian commented May 21, 2023 •
edited
Loading

There's an issue with the local dev server running in Safari that might be an issue with a Safari-based extension as well. The issue is Failed to load resource: The operation couldn’t be completed. (WebKitBlobResource error 1.) and the blob is failed to loaded and then turned into a URL. This doesn't happen with every page refresh but it happens constant enough that it's unstable. This might be related to this stackoverflow post with the solution being storing the blob in indexed db differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add generated safari xcode project chadian/vorfreude
1 participant
@chadian