Update to extension manifest v3 #39
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadian
commented
Oct 17, 2022
| "version": "{{packageVersion}}", | ||
| "manifest_version": 2, | ||
| "browser_action": { | ||
| "version": "0.0.0", |
There was a problem hiding this comment.
This gets populated by yarn build:version-manifest in the chrome folder
|
Looks like I might have jumped the gun on this one, Firefox doesn't support manifest version 3. This means that #8 and #7 can probably proceed and hopefully manifest version 3 gets more stable across all browsers. Until then, I'll stick with version 2 although there are still some useful refactors that could be pulled from this branch, like making |
|
Firefox now supports manifest v3. This might be ready to go now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves compatibility and futureproofs the extension by upgrading to manifest v3 and updating breaking changes. More details at Chrome's Welcome to Manifest V3. Some of the changes included here:
sveltekit-adapter-chrome-extensioninstead of static to avoid CSP issuesbackgroundscriptschromethe idempotent output build folder from runningyarn build, no longer using some symlinks, and makes it directly packagable after.